Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the relevant APIs of StatsError. #4339

Closed
ityuany opened this issue Oct 17, 2023 · 5 comments
Closed

Improve the relevant APIs of StatsError. #4339

ityuany opened this issue Oct 17, 2023 · 5 comments
Assignees
Labels
feat New feature or request

Comments

@ityuany
Copy link
Contributor

ityuany commented Oct 17, 2023

What problem does this feature solve?

see friendly-errors-webpack-plugin , We need to implement similar functionality. This functionality requires extracting information such as StatsError stack, moduleId, etc. Currently, the api for rspack StatsError is not perfect.

What does the proposed API of configuration look like?

like webpack StatsError

@ityuany ityuany added feat New feature or request pending triage The issue/PR is currently untouched. labels Oct 17, 2023
@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Oct 17, 2023
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Oct 17, 2023

Related #4326

Copy link

stale bot commented Dec 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 16, 2023
@stale stale bot removed the stale label Jul 2, 2024
@hardfist
Copy link
Contributor

hardfist commented Jul 2, 2024

bump

@LingyuCoder
Copy link
Collaborator

Most of StatsError fields had been aligned with webpack:

export interface JsStatsError {
  message: string
  chunkName?: string
  chunkEntry?: boolean
  chunkInitial?: boolean
  file?: string
  moduleIdentifier?: string
  moduleName?: string
  moduleId?: string
  chunkId?: string
  details?: string
  stack?: string
  moduleTrace: Array<JsStatsModuleTrace>
}

Cause the error handling of rspack on the rust side cannot be completely consistent with nodejs of webpack. Can these fields meet your needs?

@LingyuCoder
Copy link
Collaborator

I will close this issue as completed. If you meet some problem again, please just reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants