Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move orphaned role tests into tentative files #645

Closed
nmlapre opened this issue Mar 11, 2024 · 6 comments
Closed

Move orphaned role tests into tentative files #645

nmlapre opened this issue Mar 11, 2024 · 6 comments
Assignees
Labels
focus area: Accessibility test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nmlapre
Copy link

nmlapre commented Mar 11, 2024

Test List

  • in grid-roles.html:
    • orphaned button with gridcell role outside the context of row
    • orphaned row outside the context of table
    • orphaned rowgroup outside the context of row
    • orphaned div with gridcell role outside the context of row
    • orphaned rowheader outside the context of row
    • orphaned columnheader outside the context of row
  • in list-roles.html:
    • orphan p with listitem role
  • in listbox-roles.html:
    • orphaned option outside the context of listbox
  • in menu-roles.html:
    • orphaned menuitem outside the context of menu/menubar
    • orphaned menuitemradio outside the context of menu/menubar
    • orphaned menuitemcheckbox outside the context of menu/menubar
    • orphan button with menuitem role
    • orphan button with menuitemcheckbox role
    • orphan button with menuitemradio role
  • in tab-roles.html:
    • orphan button with tab role
  • in tree-roles.html:
    • orphaned treeitem outside the context of tree
    • orphaned button with treeitem role outside tree context

Rationale

Please see rationale in web-platform-tests/interop-accessibility#109.

Since these tests aren't currently supported by the spec, I think we should move them to a .tentative file or files.

@foolip
Copy link
Member

foolip commented Mar 12, 2024

Is the proposal just to rename the tests to make clear they're not backed by a spec, or to also drop them from Interop 2024? We have on a few occasions included tentative tests, but it's worth flagging when we do that since the tests themselves are then the only guide to implementation.

@nairnandu
Copy link
Contributor

@aleventhal could you please review the proposal for Chromium?
@nt1m could you please review for WebKit?

@nt1m
Copy link
Member

nt1m commented Mar 12, 2024

@cookiecrook Can you help review for WebKit?

@aleventhal
Copy link

I agree that there is no requirement for browsers to ignore orphaned roles where they are missing a required ancestor, etc.
If we're ever going to make that a requirement it needs to be discussed in ARIA WG because of potential performance and behavioral regressions.

@nmlapre
Copy link
Author

nmlapre commented Mar 12, 2024

Is the proposal just to rename the tests to make clear they're not backed by a spec, or to also drop them from Interop 2024?

I'd prefer to drop the tests from Interop 2024, unless the ARIA spec issue is resolved quite soon. I was under the impression that renaming with .tentative was tantamount to removal for Interop 2024 (see comment here), but maybe I'm wrong on that. I'm happy to pull them out entirely.

@cookiecrook
Copy link

As mentioned in web-platform-tests/wpt#45032, there are spec requirements in Core-AAM for this. The discussion is happening there, so I don’t think these tests will be pulled out of the Focus Area, until implementors wish to change Core-AAM.

There’s also an open ARIA Issue and an Interop-Accessibility issue:

@nmlapre nmlapre closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Accessibility test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

7 participants