Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Edge runs are too slow (20-30h) #623

Open
foolip opened this issue Nov 5, 2018 · 3 comments
Open

Edge runs are too slow (20-30h) #623

foolip opened this issue Nov 5, 2018 · 3 comments

Comments

@foolip
Copy link
Member

foolip commented Nov 5, 2018

Hovering the recent runs on https://wpt.fyi/test-runs?product=edge, Edge runs have taken 20-30h.

This is probably due to 27c22db.

@gsnedders
Copy link
Member

And despite @jugglinmike's theory, it hasn't made the results any more reliable AFAICT.

@jugglinmike
Copy link
Collaborator

Both the increase in time-to-results and the negligible effect on correctness were expected:

Do you think it'd be worth trying more aggressive restarting

The fact that this immediately interferes with almost every "chunk" makes me think that restarting will not resolve it, but it couldn't hurt to try (especially now that we're disabling Safari on Sauce Labs). We'll see what effect this has on time-to-results (it may get ugly).

As anticipated, the results continue to be invalid. From later on in that discussion thread:

We've completed a collection from Edge that involved restarting after every test failure. This increased build time from 15 hours to 24 hours, but it had no appreciable affect on the veracity of the results.

There's little value in improving the time-to-results without fixing the underlying problem. Since the fix will itself shorten the duration to some extent, I'm going to hold off on reverting the referenced commit.

@foolip
Copy link
Member Author

foolip commented Nov 9, 2018

https://wpt.fyi/results/?sha=349d418380&label=stable took 19 hours, so that below the range I observed, but very narrowly.

@foolip foolip mentioned this issue Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants