From 23cf7e6a8ea1775ca7288649256bf038d5f7b312 Mon Sep 17 00:00:00 2001 From: Mason Freed Date: Mon, 13 Feb 2023 14:46:07 -0800 Subject: [PATCH] Rip out all of the beautiful bespoke Popover animation stuff This isn't part of the landed spec [1], and will be replaced by a combination of these five CSSWG issues: - https://github.com/w3c/csswg-drafts/issues/4441 - https://github.com/w3c/csswg-drafts/issues/6429 - https://github.com/w3c/csswg-drafts/issues/8174 - https://github.com/w3c/csswg-drafts/issues/8189 - https://github.com/w3c/csswg-drafts/issues/8389 After this CL, you will no longer be able to animate your popover like this: ``` [popover] { opacity: 0; transition: opacity 0.2s; } [popover]:open { opacity: 1; } ``` Instead you'll need to use CSS animations or (eventually) transitions and you'll have to explicitly declare the `display` and `top-layer` properties: ``` transition: opacity 0.2s, display 0.2s, top-layer 0.2s; ``` [1] https://html.spec.whatwg.org/multipage/popover.html Bug: 1307772,1413556 Change-Id: I4877dd69a06f2624bdb463b065b2e2b66cbf1154 --- ...opover-animated-display-ref.tentative.html | 26 -- ...pover-animated-hide-cleanup.tentative.html | 98 -------- ...pover-animated-hide-display.tentative.html | 57 ----- ...-animated-hide-finishes-ref.tentative.html | 16 -- ...over-animated-hide-finishes.tentative.html | 56 ----- ...pover-animated-show-display.tentative.html | 52 ---- ...over-animation-corner-cases.tentative.html | 230 ------------------ .../popover-attribute-basic.tentative.html | 30 --- .../popovers/popover-focus.tentative.html | 42 +--- 9 files changed, 12 insertions(+), 595 deletions(-) delete mode 100644 html/semantics/popovers/popover-animated-display-ref.tentative.html delete mode 100644 html/semantics/popovers/popover-animated-hide-cleanup.tentative.html delete mode 100644 html/semantics/popovers/popover-animated-hide-display.tentative.html delete mode 100644 html/semantics/popovers/popover-animated-hide-finishes-ref.tentative.html delete mode 100644 html/semantics/popovers/popover-animated-hide-finishes.tentative.html delete mode 100644 html/semantics/popovers/popover-animated-show-display.tentative.html delete mode 100644 html/semantics/popovers/popover-animation-corner-cases.tentative.html diff --git a/html/semantics/popovers/popover-animated-display-ref.tentative.html b/html/semantics/popovers/popover-animated-display-ref.tentative.html deleted file mode 100644 index 477a97c12ccd9dc..000000000000000 --- a/html/semantics/popovers/popover-animated-display-ref.tentative.html +++ /dev/null @@ -1,26 +0,0 @@ - - - -
-
This is a popover
- - - diff --git a/html/semantics/popovers/popover-animated-hide-cleanup.tentative.html b/html/semantics/popovers/popover-animated-hide-cleanup.tentative.html deleted file mode 100644 index 9310acc4ff20980..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-cleanup.tentative.html +++ /dev/null @@ -1,98 +0,0 @@ - - - - - - - - - - - - - -I am a dialog - - - - diff --git a/html/semantics/popovers/popover-animated-hide-display.tentative.html b/html/semantics/popovers/popover-animated-hide-display.tentative.html deleted file mode 100644 index 5a59a9556daa8a1..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-display.tentative.html +++ /dev/null @@ -1,57 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animated-hide-finishes-ref.tentative.html b/html/semantics/popovers/popover-animated-hide-finishes-ref.tentative.html deleted file mode 100644 index d8334f985ed51f3..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-finishes-ref.tentative.html +++ /dev/null @@ -1,16 +0,0 @@ - - -
- - diff --git a/html/semantics/popovers/popover-animated-hide-finishes.tentative.html b/html/semantics/popovers/popover-animated-hide-finishes.tentative.html deleted file mode 100644 index 79e0b4dcbf67400..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-finishes.tentative.html +++ /dev/null @@ -1,56 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animated-show-display.tentative.html b/html/semantics/popovers/popover-animated-show-display.tentative.html deleted file mode 100644 index f78d8e1236fcec0..000000000000000 --- a/html/semantics/popovers/popover-animated-show-display.tentative.html +++ /dev/null @@ -1,52 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animation-corner-cases.tentative.html b/html/semantics/popovers/popover-animation-corner-cases.tentative.html deleted file mode 100644 index f41f7a68df9058d..000000000000000 --- a/html/semantics/popovers/popover-animation-corner-cases.tentative.html +++ /dev/null @@ -1,230 +0,0 @@ - - - - - - - - - - - - - diff --git a/html/semantics/popovers/popover-attribute-basic.tentative.html b/html/semantics/popovers/popover-attribute-basic.tentative.html index 9b03c7bc1c65a14..13732a58f3a42d7 100644 --- a/html/semantics/popovers/popover-attribute-basic.tentative.html +++ b/html/semantics/popovers/popover-attribute-basic.tentative.html @@ -32,16 +32,8 @@ Dialog without popover attribute -
Animated popover