From 2e4bf18e1bac0d91d397ccbeaa7152cd32661bf5 Mon Sep 17 00:00:00 2001
From: Mason Freed <masonf@chromium.org>
Date: Fri, 11 Nov 2022 17:28:51 -0800
Subject: [PATCH] Remove the popover `defaultopen` attribute

Per the [1] resolution, we have decided to remove this feature
for now, while we work on ways to make it more generic and
applicable to other elements such as `<details>` and `<dialog>`.

[1] https://github.com/openui/open-ui/issues/631#issuecomment-1310815390

Bug: 1307772
Change-Id: I7bc385fcbe1fadfcdf83d2d65c2e46abc07cb8a4
---
 .../popover-anchor-display.tentative.html     |  5 +++
 .../popover-defaultopen-2.tentative.html      | 24 ----------
 ...ver-defaultopen-display-ref.tentative.html |  6 ---
 ...popover-defaultopen-display.tentative.html | 14 ------
 .../popover-defaultopen.tentative.html        | 44 -------------------
 ...over-top-layer-combinations.tentative.html |  1 +
 .../popovers/resources/popover-utils.js       | 31 +++++++++++++
 7 files changed, 37 insertions(+), 88 deletions(-)
 delete mode 100644 html/semantics/popovers/popover-defaultopen-2.tentative.html
 delete mode 100644 html/semantics/popovers/popover-defaultopen-display-ref.tentative.html
 delete mode 100644 html/semantics/popovers/popover-defaultopen-display.tentative.html
 delete mode 100644 html/semantics/popovers/popover-defaultopen.tentative.html
diff --git a/html/semantics/popovers/popover-anchor-display.tentative.html b/html/semantics/popovers/popover-anchor-display.tentative.html
index 03b486d745dd58..103bc9849fdbd6 100644
--- a/html/semantics/popovers/popover-anchor-display.tentative.html
+++ b/html/semantics/popovers/popover-anchor-display.tentative.html
@@ -3,6 +3,7 @@
 <link rel=author href="mailto:masonf@chromium.org">
 <link rel=help href="https://open-ui.org/components/popup.research.explainer">
 <link rel=match href="popover-anchor-display-ref.tentative.html">
+<script src="resources/popover-utils.js"></script>
 
 <p>There should be a green box attached to the right side of each orange box.</p>
 
@@ -24,6 +25,10 @@
   <div id=popover3 popover=manual defaultopen></div>
 </div>
 
+<script>
+showDefaultopenPopoversOnLoad();
+</script>
+
 <style>
   .ex {
     margin: 25px;
diff --git a/html/semantics/popovers/popover-defaultopen-2.tentative.html b/html/semantics/popovers/popover-defaultopen-2.tentative.html
deleted file mode 100644
index 4ed78609f5c42b..00000000000000
--- a/html/semantics/popovers/popover-defaultopen-2.tentative.html
+++ /dev/null
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<meta charset="utf-8">
-<link rel=author href="mailto:masonf@chromium.org">
-<link rel=help href="https://open-ui.org/components/popup.research.explainer">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-
-<div popover id=p1 defaultopen>
-  Outer popover
-  <div popover id=p2 defaultopen>
-    Inner popover
-  </div>
-</div>
-
-<script>
-  requestAnimationFrame(() => {
-    requestAnimationFrame(() => {
-      test(function(){
-        assert_true(p1.matches(':open'),'The first (outermost) popover should be the one that opens in this case');
-        assert_false(p2.matches(':open'),'The inner popover should not be open');
-      }, "The defaultopen attribute should cause only the first popover to open");
-    });
-  });
-</script>
diff --git a/html/semantics/popovers/popover-defaultopen-display-ref.tentative.html b/html/semantics/popovers/popover-defaultopen-display-ref.tentative.html
deleted file mode 100644
index 8973616308b854..00000000000000
--- a/html/semantics/popovers/popover-defaultopen-display-ref.tentative.html
+++ /dev/null
@@ -1,6 +0,0 @@
-<!DOCTYPE html>
-<meta charset="utf-8">
-<link rel=author href="mailto:masonf@chromium.org">
-<link rel="stylesheet" href="resources/popover-styles.css">
-
-<div class="fake-popover">This is a popover, which should be open upon load</div>
diff --git a/html/semantics/popovers/popover-defaultopen-display.tentative.html b/html/semantics/popovers/popover-defaultopen-display.tentative.html
deleted file mode 100644
index d624289a27a480..00000000000000
--- a/html/semantics/popovers/popover-defaultopen-display.tentative.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<meta charset="utf-8">
-<link rel=author href="mailto:masonf@chromium.org">
-<link rel=help href="https://open-ui.org/components/popup.research.explainer">
-<link rel=match href="popover-defaultopen-display-ref.tentative.html">
-
-<div popover id=p1 defaultopen>This is a popover, which should be open upon load</div>
-<div popover id=p2 defaultopen>This is a second popover with defaultopen, which should NOT be open upon load</div>
-
-<style>
-  #p2 {
-    top:100px;
-  }
-</style>
diff --git a/html/semantics/popovers/popover-defaultopen.tentative.html b/html/semantics/popovers/popover-defaultopen.tentative.html
deleted file mode 100644
index daf12f7ff5afc7..00000000000000
--- a/html/semantics/popovers/popover-defaultopen.tentative.html
+++ /dev/null
@@ -1,44 +0,0 @@
-<!DOCTYPE html>
-<meta charset="utf-8">
-<link rel=author href="mailto:masonf@chromium.org">
-<link rel=help href="https://open-ui.org/components/popup.research.explainer">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-
-<div popover id=p1 defaultopen>This is a popover, which should be open upon load</div>
-<script></script> <!-- Possibly yield the parser, just to double-check -->
-<div popover id=p2 defaultopen>This is a second popover with defaultopen, which should NOT be open upon load</div>
-<div popover id=p3>Also not visible</div>
-
-<div popover=manual id=p4 defaultopen>This is a manual popover with defaultopen, which should be open upon load</div>
-<div popover=manual id=p5 defaultopen>This is a manual popover with defaultopen, which should be open upon load</div>
-
-<script>
-  requestAnimationFrame(() => {
-    requestAnimationFrame(() => {
-      test(function(){
-        assert_true(p1.matches(':open'),'defaultopen should open the popover');
-        assert_true(p1.hasAttribute('defaultopen'));
-        assert_true(p1.defaultOpen,'defaultopen should be reflected in the IDL attribute');
-        assert_false(p2.matches(':open'), 'Only the first popover with defaultopen should be open on load');
-        assert_true(p2.hasAttribute('defaultopen'),'defaultopen should be present/true, even if not opened');
-        assert_true(p2.defaultOpen,'defaultopen should be present/true, even if not opened');
-
-        assert_true(p4.matches(':open'),'defaultopen should open all manual popovers');
-        assert_true(p5.matches(':open'),'defaultopen should open all manual popovers');
-
-        assert_false(p3.matches(':open'));
-        p3.setAttribute('defaultopen','');
-        assert_false(p3.matches(':open'), 'Changing defaultopen should not affect open status');
-        assert_true(p3.hasAttribute('defaultopen'));
-        assert_true(p3.defaultOpen,'defaultopen should still reflect to IDL');
-
-        p1.removeAttribute('defaultopen');
-        assert_true(p1.matches(':open'),'removing defaultopen should not close the popover');
-        assert_false(p1.hasAttribute('defaultopen'),'...but it should reflect to IDL');
-
-        p1.hidePopover();
-      }, "The defaultopen attribute should affect page load only");
-    });
-  });
-</script>
diff --git a/html/semantics/popovers/popover-top-layer-combinations.tentative.html b/html/semantics/popovers/popover-top-layer-combinations.tentative.html
index 66106ce17d9afe..d4529b9e39c87a 100644
--- a/html/semantics/popovers/popover-top-layer-combinations.tentative.html
+++ b/html/semantics/popovers/popover-top-layer-combinations.tentative.html
@@ -29,6 +29,7 @@
 </style>
 
 <script>
+showDefaultopenPopoversOnLoad();
 const isDialog = (ex) => ex instanceof HTMLDialogElement;
 const isFullscreen = (ex) => ex.classList.contains('fullscreen');
 function ensureIsOpenPopover(ex,message) {
diff --git a/html/semantics/popovers/resources/popover-utils.js b/html/semantics/popovers/resources/popover-utils.js
index be10017e5feb87..804a0830e5fbbe 100644
--- a/html/semantics/popovers/resources/popover-utils.js
+++ b/html/semantics/popovers/resources/popover-utils.js
@@ -73,3 +73,34 @@ async function blessTopLayer(visibleElement) {
   await wait_click;
   button.remove();
 }
+// This is a "polyfill" of sorts for the `defaultopen` attribute.
+// It can be called before window.load is complete, and it will
+// show defaultopen popovers according to the rules previously part
+// of the popover API: any popover=manual popover can be shown this
+// way, and only the first popover=auto popover.
+function showDefaultopenPopoversOnLoad() {
+  function show() {
+    const popovers = Array.from(document.querySelectorAll('[popover][defaultopen]'));
+    popovers.forEach((p) => {
+        // The showPopover calls below aren't guarded by a check on the popover
+        // open/closed status. If they throw exceptions, this function was
+        // probably called at a bad time.
+        switch (p.popover) {
+        case 'auto':
+          if (!document.querySelector('[popover]:open')) {
+            p.showPopover();
+          }
+          break;
+        case 'manual':
+          p.showPopover();
+        default:
+          assert_notreached(`Unknown popover type ${p.popover}`);
+      }
+    });
+  }
+  if (document.readyState === 'complete') {
+    show();
+  } else {
+    window.addEventListener('load',show,{once:true});
+  }
+}
