From aac0fa855bcea896bf6e03395243cb1e3ec133a0 Mon Sep 17 00:00:00 2001 From: Ting-Yu Lin Date: Mon, 20 Sep 2021 15:57:58 +0000 Subject: [PATCH] Part 4 - Cache flex item's border and padding used in the final reflow. Currently, we assume any flex item with percentage padding will be marked as dirty if the percentage basis is changed. However, it is not true. To fix it, we cache the flex item's border and padding used in its most recent final reflow to detect their changes. dynamic-isize-change-004.html is designed to catch the concern in bug 1700580 comment 12. Differential Revision: https://phabricator.services.mozilla.com/D125620 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1700580 gecko-commit: 3da0171aa06ec5a340f0568b9772a68cee5572a3 gecko-reviewers: dholbert --- css/css-flexbox/dynamic-isize-change-002.html | 40 +++++++++++++++++ css/css-flexbox/dynamic-isize-change-003.html | 43 +++++++++++++++++++ css/css-flexbox/dynamic-isize-change-004.html | 42 ++++++++++++++++++ 3 files changed, 125 insertions(+) create mode 100644 css/css-flexbox/dynamic-isize-change-002.html create mode 100644 css/css-flexbox/dynamic-isize-change-003.html create mode 100644 css/css-flexbox/dynamic-isize-change-004.html diff --git a/css/css-flexbox/dynamic-isize-change-002.html b/css/css-flexbox/dynamic-isize-change-002.html new file mode 100644 index 00000000000000..cc859b73f9ae94 --- /dev/null +++ b/css/css-flexbox/dynamic-isize-change-002.html @@ -0,0 +1,40 @@ + + +CSS Flexbox Test: Dynamic change to the inline-size of a row flex container + + + + + + + + +

Test passes if there is a filled green square and no red.

+
+
+
+ + diff --git a/css/css-flexbox/dynamic-isize-change-003.html b/css/css-flexbox/dynamic-isize-change-003.html new file mode 100644 index 00000000000000..9df13e313fda0b --- /dev/null +++ b/css/css-flexbox/dynamic-isize-change-003.html @@ -0,0 +1,43 @@ + + +CSS Flexbox Test: Dynamic change to the inline-size of a column flexbox container + + + + + + + + +

Test passes if there is a filled green square and no red.

+
+
+
+ + diff --git a/css/css-flexbox/dynamic-isize-change-004.html b/css/css-flexbox/dynamic-isize-change-004.html new file mode 100644 index 00000000000000..1627e32d966d92 --- /dev/null +++ b/css/css-flexbox/dynamic-isize-change-004.html @@ -0,0 +1,42 @@ + + +CSS Flexbox Test: Dynamic change to the inline-size of a row flex container + + + + + + + + + +

Test passes if there is a filled green square and no red.

+
+
XXXX
+
+ +