From ad2ac854581cbf4193298bcc75310eedc5ebbb99 Mon Sep 17 00:00:00 2001 From: Simon Pieters Date: Thu, 18 Oct 2018 09:49:54 +0200 Subject: [PATCH] Address comments --- .../the-fieldset-element/accessibility/README.md | 2 +- .../accessibility/aria-manual.html | 4 ++-- .../accessibility/baseline-manual.html | 5 +++-- .../fieldset-appearance-none-manual.html | 5 +++-- .../fieldset-display-contents-manual.html | 5 +++-- .../accessibility/fieldset-display-none-manual.html | 11 +++++++++++ .../fieldset-div-display-contents-manual.html | 5 +++-- .../accessibility/fieldset-role-none-manual.html | 5 +++-- .../fieldset-role-presentation-manual.html | 7 ++++--- .../fieldset-visibility-collapse-manual.html | 11 +++++++++++ .../fieldset-visibility-hidden-manual.html | 12 ++++++++++++ .../accessibility/flexbox-manual.html | 5 +++-- .../accessibility/grid-manual.html | 5 +++-- .../accessibility/legend-abspos-manual.html | 5 +++-- .../legend-child-display-none-manual.html | 5 +++-- .../legend-child-visibility-hidden-manual.html | 5 +++-- .../legend-display-contents-manual.html | 5 +++-- .../accessibility/legend-display-none-manual.html | 5 +++-- .../accessibility/legend-float-manual.html | 5 +++-- .../accessibility/legend-role-group-manual.html | 3 ++- .../legend-visibility-collapse-manual.html | 11 +++++++++++ .../legend-visibility-hidden-manual.html | 5 +++-- .../accessibility/multiple-legends-manual.html | 6 ++++-- .../accessibility/role-manual.html | 8 ++++++++ .../accessibility/shadow-dom-manual.html | 5 +++-- .../title-attribute-and-empty-legend-manual.html | 5 +++-- 26 files changed, 114 insertions(+), 41 deletions(-) create mode 100644 html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-none-manual.html create mode 100644 html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-collapse-manual.html create mode 100644 html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-hidden-manual.html create mode 100644 html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-collapse-manual.html create mode 100644 html/semantics/forms/the-fieldset-element/accessibility/role-manual.html diff --git a/html/semantics/forms/the-fieldset-element/accessibility/README.md b/html/semantics/forms/the-fieldset-element/accessibility/README.md index ba830d8a81dcb7e..b238a023dc1344b 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/README.md +++ b/html/semantics/forms/the-fieldset-element/accessibility/README.md @@ -5,7 +5,7 @@ These tests are intended to test the accessibility of the fieldset and legend el To run these tests, open the browser's developer tools and navigate to the Accessibility pane (may need to activate it in Settings), or use an OS-level accessibility inspector, and verify that the -accessible name matches the expected accessible name. +accessible name/role matches the expected accessible name/role. The following issue discusses ways to automate these tests: diff --git a/html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html index e806198d6ae2336..c61d62769acdd8b 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html @@ -1,7 +1,7 @@ fieldset accessibility test: ARIA -
+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/baseline-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/baseline-manual.html index c0be1db2d8a9a62..2ee1ab20e95924d 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/baseline-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/baseline-manual.html @@ -1,7 +1,8 @@ fieldset accessibility test: baseline -

+ +
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-appearance-none-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-appearance-none-manual.html index cdd494a85bcd14f..dbc4edc2a261b3e 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-appearance-none-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-appearance-none-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: fieldset -webkit-appearance: none + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-contents-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-contents-manual.html index 5a419f4fc5f5f92..943a030337b34a7 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-contents-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-contents-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: fieldset display: contents + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-none-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-none-manual.html new file mode 100644 index 000000000000000..b45576036a3037c --- /dev/null +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-display-none-manual.html @@ -0,0 +1,11 @@ + +fieldset accessibility test: fieldset display: none + + +

+ Foo + +
+

Expected no accessible node for id=fieldset. diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-div-display-contents-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-div-display-contents-manual.html index 346851ad61504dd..2eb01f2a711d751 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-div-display-contents-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-div-display-contents-manual.html @@ -1,12 +1,13 @@ fieldset accessibility test: fieldset div display: contents + -

+
Foo
-

Expected accessible name: "" +

Expected accessible name for id=fieldset: "" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-none-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-none-manual.html index 7563f5ac85853fd..4638a2b8d1315f9 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-none-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-none-manual.html @@ -1,7 +1,8 @@ fieldset accessibility test: fieldset role=none -

+ +
Foo
-

Expected no accessible node for the fieldset. +

Expected no accessible node for id=fieldset. diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-presentation-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-presentation-manual.html index 87e2c5e79d1dd99..e1360d29c9ac0e3 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-presentation-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-role-presentation-manual.html @@ -1,7 +1,8 @@ -fieldset accessibility test: fieldset role=none -

+fieldset accessibility test: fieldset role=presentation + + -

Expected no accessible node for the fieldset. +

Expected no accessible node for id=fieldset. diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-collapse-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-collapse-manual.html new file mode 100644 index 000000000000000..a3dd273bbe376f5 --- /dev/null +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-collapse-manual.html @@ -0,0 +1,11 @@ + +fieldset accessibility test: fieldset visibility: collapse + + +

+ Foo + +
+

Expected no accessible node for id=fieldset. diff --git a/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-hidden-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-hidden-manual.html new file mode 100644 index 000000000000000..894f00af527f910 --- /dev/null +++ b/html/semantics/forms/the-fieldset-element/accessibility/fieldset-visibility-hidden-manual.html @@ -0,0 +1,12 @@ + +fieldset accessibility test: fieldset visibility: hidden + + +

+ Foo + +
+

Expected no accessible node for id=fieldset. diff --git a/html/semantics/forms/the-fieldset-element/accessibility/flexbox-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/flexbox-manual.html index 25efd74624c3b65..2d3d2a929cff95f 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/flexbox-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/flexbox-manual.html @@ -1,12 +1,13 @@ fieldset accessibility test: flexbox + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/grid-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/grid-manual.html index c68749379391439..9d966d0113978b1 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/grid-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/grid-manual.html @@ -1,11 +1,12 @@ fieldset accessibility test: grid + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-abspos-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-abspos-manual.html index e389c46513e03e4..019e63fcd364423 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-abspos-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-abspos-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: position: absolute legend + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-child-display-none-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-child-display-none-manual.html index 91f162e046d4516..bc5d9fb7f621778 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-child-display-none-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-child-display-none-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: legend child display: none + -

+
FooBar
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-child-visibility-hidden-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-child-visibility-hidden-manual.html index 559039de548e255..01ceb9ec65b6482 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-child-visibility-hidden-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-child-visibility-hidden-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: legend visibility: hidden + -

+
FooBar
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-display-contents-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-display-contents-manual.html index 377fca73f3dc1f0..f9fd1a31b8d1d05 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-display-contents-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-display-contents-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: legend display: contents + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-display-none-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-display-none-manual.html index e0fad9c718f84f7..14060b99f8309aa 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-display-none-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-display-none-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: legend display: none + -

+
Foo
-

Expected accessible name: "" +

Expected accessible name for id=fieldset: "" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-float-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-float-manual.html index 026e24e14a15cc9..40f2c4ac2360fe8 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-float-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-float-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: floating legend + -

+
Foo
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-role-group-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-role-group-manual.html index 875a93742bb6997..e15ff4d810aa5bf 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-role-group-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-role-group-manual.html @@ -1,7 +1,8 @@ fieldset accessibility test: legend role=group aria-labelledby=fieldset +

Foo
-

Expected accessible name: "" +

Expected accessible name for id=fieldset: "" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-collapse-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-collapse-manual.html new file mode 100644 index 000000000000000..c44bb1e88846d05 --- /dev/null +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-collapse-manual.html @@ -0,0 +1,11 @@ + +fieldset accessibility test: legend visibility: collapse + + +

+ Foo + +
+

Expected accessible name for id=fieldset: "" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-hidden-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-hidden-manual.html index 173ce6dd436586b..f989712565c202f 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-hidden-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/legend-visibility-hidden-manual.html @@ -1,10 +1,11 @@ fieldset accessibility test: legend visibility: hidden + -

+
Foo
-

Expected accessible name: "" +

Expected accessible name for id=fieldset: "" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/multiple-legends-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/multiple-legends-manual.html index 6192aad183028b0..5d25317ad01a38d 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/multiple-legends-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/multiple-legends-manual.html @@ -1,8 +1,10 @@ fieldset accessibility test: multiple legends -

+ +
+
Foo Bar
-

Expected accessible name: "Foo" +

Expected accessible name for id=fieldset: "Foo" diff --git a/html/semantics/forms/the-fieldset-element/accessibility/role-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/role-manual.html new file mode 100644 index 000000000000000..d09c203b6b85d70 --- /dev/null +++ b/html/semantics/forms/the-fieldset-element/accessibility/role-manual.html @@ -0,0 +1,8 @@ + +fieldset accessibility test: role +

+ Foo + +
+

Expected accessible role for id=fieldset: "group" +

Expected accessible role for id=legend: No corresponding role diff --git a/html/semantics/forms/the-fieldset-element/accessibility/shadow-dom-manual.html b/html/semantics/forms/the-fieldset-element/accessibility/shadow-dom-manual.html index 0e05807bf3bf1cb..bb93d07644f3d3d 100644 --- a/html/semantics/forms/the-fieldset-element/accessibility/shadow-dom-manual.html +++ b/html/semantics/forms/the-fieldset-element/accessibility/shadow-dom-manual.html @@ -1,7 +1,8 @@ fieldset accessibility test: shadow DOM +