From f4dbd64bf67bc396e2faf2a5aef97beb8a05af22 Mon Sep 17 00:00:00 2001 From: David Baron Date: Wed, 25 Oct 2023 07:01:55 -0700 Subject: [PATCH] Revert "Give element default unicode-bidi: isolate style." This reverts commit 198d41cfd6eac5fd9ee34e6314e34f938b6d31b5. Reason for revert: This reverts a change that was the first of two closely related changes. Given that the other change, in https://crrev.com/c/4973701, turned out to have problems (and I haven't attempted to land it), I've proposed reverting both in the HTML spec at https://github.com/whatwg/html/pull/9880. I'm therefore reverting this (the first half) until the HTML spec discussion is sorted out. Original change's description: > Give element default unicode-bidi: isolate style. > > This is behind the RuntimeEnabledFeatures::CSSPseudoDirEnabled() flag. > > This implements a part of the behavior described in: > https://github.com/whatwg/html/issues/3699#issuecomment-951423468 > which has been specified in: > https://github.com/whatwg/html/pull/9554 > https://github.com/whatwg/html/pull/9796 > > Bug: 576815 > Change-Id: Ice471838c7251fc69d87abfa723f3eef1a4c455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4800075 > Reviewed-by: Chris Harrelson > Reviewed-by: Di Zhang > Commit-Queue: David Baron > Cr-Commit-Position: refs/heads/main@{#1214439} Bug: 576815 Change-Id: I0f52b30c345d4962a36a36e5d2651221db96bcde No-Presubmit: true No-Tree-Checks: true No-Try: true --- .../bidi-rendering/slot-isolate-001-ref.html | 8 ------- .../bidi-rendering/slot-isolate-001.html | 22 ------------------- 2 files changed, 30 deletions(-) delete mode 100644 html/rendering/bidi-rendering/slot-isolate-001-ref.html delete mode 100644 html/rendering/bidi-rendering/slot-isolate-001.html diff --git a/html/rendering/bidi-rendering/slot-isolate-001-ref.html b/html/rendering/bidi-rendering/slot-isolate-001-ref.html deleted file mode 100644 index 64a8db06c01c749..000000000000000 --- a/html/rendering/bidi-rendering/slot-isolate-001-ref.html +++ /dev/null @@ -1,8 +0,0 @@ - -HTML Rendering: slot element has unicode-bidi: isolate - - - -
א-ב
- -
isolate
diff --git a/html/rendering/bidi-rendering/slot-isolate-001.html b/html/rendering/bidi-rendering/slot-isolate-001.html deleted file mode 100644 index edffd6c79b6e418..000000000000000 --- a/html/rendering/bidi-rendering/slot-isolate-001.html +++ /dev/null @@ -1,22 +0,0 @@ - -HTML Rendering: slot element has unicode-bidi: isolate - - - - - - -
א-ב
- -
- -