Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of product.__wptrunner__ #14467

Open
gsnedders opened this issue Dec 11, 2018 · 4 comments
Open

Get rid of product.__wptrunner__ #14467

gsnedders opened this issue Dec 11, 2018 · 4 comments
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

gsnedders commented Dec 11, 2018

This is something that I've mentioned in various PRs when we've been refactoring code around this; #13966 changed the loading side to create an object, but really this object should be created within the browser module.

There are a number of reasons to do this, partly code cleanliness, but perhaps the most useful feature would be to make it possible to change the executor for a browser based on command line args, thereby avoiding having to duplicate the browser for multiple executors (as we currently have for Edge, and will soon have for Chrome).

@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run priority:roadmap labels Dec 11, 2018
@foolip
Copy link
Member

foolip commented Mar 15, 2019

@gsnedders I'll downgrade the prioritiy of this since it hasn't shown up in our planning and doesn't have an assignee.

@gsnedders
Copy link
Member Author

@foolip I've expanded the description here; I'd probably say it's something we should definitely do as part of the Chrome/CDP work (so it's a command line argument rather than a separate product).

@foolip
Copy link
Member

foolip commented Mar 18, 2019

Will it still be possible to have separate expectations in infrastructure/ for different executors?

@jgraham
Copy link
Contributor

jgraham commented Mar 18, 2019

We may need to change things so that the expectations can be per-browser or per-executor, but that's possible to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

3 participants