From 9f5e0e683bf0bbeb51349bbea68b67526277965e Mon Sep 17 00:00:00 2001 From: Brian Burg Date: Mon, 16 Jul 2018 16:05:19 -0700 Subject: [PATCH] WebDriver: fix expected key code for 'Unidentified' keys. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per the UI Events specification (https://w3c.github.io/uievents-code/#key-legacy), keys such as \u00e0 (i.e., à) should have a code of "Unidentified". Some tests in key.py expect an empty value, which seems to be an oversight. --- webdriver/tests/actions/key.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/webdriver/tests/actions/key.py b/webdriver/tests/actions/key.py index 04d46652c1a406..77b21bf4ab92e3 100644 --- a/webdriver/tests/actions/key.py +++ b/webdriver/tests/actions/key.py @@ -26,11 +26,11 @@ def test_lone_keyup_sends_no_events(session, key_reporter, key_chain): ("a", "KeyA",), (u"\"", "Quote"), (u",", "Comma"), - (u"\u00E0", ""), - (u"\u0416", ""), + (u"\u00E0", "Unidentified"), + (u"\u0416", "Unidentified"), (u"@", "Digit2"), - (u"\u2603", ""), - (u"\uF6C2", ""), # PUA + (u"\u2603", "Unidentified"), + (u"\uF6C2", "Unidentified"), # PUA ]) def test_single_printable_key_sends_correct_events(session, key_reporter,