From 4655d7f9af6064cd486f7d1fcab614504e56c953 Mon Sep 17 00:00:00 2001 From: Eric Willigers Date: Thu, 10 Jan 2019 14:21:23 +1100 Subject: [PATCH 1/3] [css-scroll-snap] Parsing some scroll-padding* Test that scroll-padding-* accept auto and accept postive length-percentage. Not yet tested: negative values, invalid values. https://drafts.csswg.org/css-scroll-snap-1/#property-index --- .../scroll-padding-block-end-valid.html | 21 +++++++++++++++ .../scroll-padding-block-start-valid.html | 21 +++++++++++++++ .../parsing/scroll-padding-block-valid.html | 25 +++++++++++++++++ .../parsing/scroll-padding-bottom-valid.html | 21 +++++++++++++++ .../scroll-padding-inline-end-valid.html | 21 +++++++++++++++ .../scroll-padding-inline-start-valid.html | 21 +++++++++++++++ .../parsing/scroll-padding-inline-valid.html | 25 +++++++++++++++++ .../parsing/scroll-padding-left-valid.html | 21 +++++++++++++++ .../parsing/scroll-padding-right-valid.html | 21 +++++++++++++++ .../parsing/scroll-padding-top-valid.html | 21 +++++++++++++++ .../parsing/scroll-padding-valid.html | 27 +++++++++++++++++++ 11 files changed, 245 insertions(+) create mode 100644 css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-block-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-inline-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-left-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-right-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-top-valid.html create mode 100644 css/css-scroll-snap/parsing/scroll-padding-valid.html diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html new file mode 100644 index 00000000000000..a0dc01c8eaadd7 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-block-end with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html new file mode 100644 index 00000000000000..e9675d5c9c1ceb --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-block-start with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html new file mode 100644 index 00000000000000..ad71d81615b01d --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html @@ -0,0 +1,25 @@ + + + + +CSS Scroll Snap Test: scroll-padding-block with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html b/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html new file mode 100644 index 00000000000000..b0d9d70048d7e9 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-bottom with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html new file mode 100644 index 00000000000000..d397d2831c609c --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-inline-end with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html new file mode 100644 index 00000000000000..38b2bb01de4082 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-inline-start with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html new file mode 100644 index 00000000000000..31123d2126f831 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html @@ -0,0 +1,25 @@ + + + + +CSS Scroll Snap Test: scroll-padding-inline with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-left-valid.html b/css/css-scroll-snap/parsing/scroll-padding-left-valid.html new file mode 100644 index 00000000000000..520c9a71208054 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-left-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-left with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-right-valid.html b/css/css-scroll-snap/parsing/scroll-padding-right-valid.html new file mode 100644 index 00000000000000..4dc461a05e0673 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-right-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-right with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-top-valid.html b/css/css-scroll-snap/parsing/scroll-padding-top-valid.html new file mode 100644 index 00000000000000..566ef06cf32b7a --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-top-valid.html @@ -0,0 +1,21 @@ + + + + +CSS Scroll Snap Test: scroll-padding-top with valid values + + + + + + + + + + diff --git a/css/css-scroll-snap/parsing/scroll-padding-valid.html b/css/css-scroll-snap/parsing/scroll-padding-valid.html new file mode 100644 index 00000000000000..a273ced2f15056 --- /dev/null +++ b/css/css-scroll-snap/parsing/scroll-padding-valid.html @@ -0,0 +1,27 @@ + + + + +CSS Scroll Snap Test: scroll-padding with valid values + + + + + + + + + + From 8b55c36e26cec42a8196f985885cbea25de00dd2 Mon Sep 17 00:00:00 2001 From: Eric Willigers Date: Fri, 11 Jan 2019 06:57:04 +1100 Subject: [PATCH 2/3] scroll-padding* calc with percentages --- css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html | 1 + .../parsing/scroll-padding-block-start-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-block-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html | 1 + .../parsing/scroll-padding-inline-start-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-inline-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-left-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-right-valid.html | 1 + css/css-scroll-snap/parsing/scroll-padding-top-valid.html | 1 + 10 files changed, 10 insertions(+) diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html index a0dc01c8eaadd7..591c155b900089 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-block-end", "10px"); test_valid_value("scroll-padding-block-end", "20%"); test_valid_value("scroll-padding-block-end", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-block-end", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html index e9675d5c9c1ceb..14d211773279fc 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-block-start", "10px"); test_valid_value("scroll-padding-block-start", "20%"); test_valid_value("scroll-padding-block-start", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-block-start", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html index ad71d81615b01d..c36437c54d5c55 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-block-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-block", "10px"); test_valid_value("scroll-padding-block", "20%"); test_valid_value("scroll-padding-block", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-block", "calc(50% + 60px)"); test_valid_value("scroll-padding-block", "1px 2px"); test_valid_value("scroll-padding-block", "1px auto"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html b/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html index b0d9d70048d7e9..a14e8a5c1c4de9 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-bottom", "10px"); test_valid_value("scroll-padding-bottom", "20%"); test_valid_value("scroll-padding-bottom", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-bottom", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html index d397d2831c609c..80b73b9f7c9fcd 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-inline-end", "10px"); test_valid_value("scroll-padding-inline-end", "20%"); test_valid_value("scroll-padding-inline-end", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-inline-end", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html index 38b2bb01de4082..8d30485c77eb81 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-inline-start", "10px"); test_valid_value("scroll-padding-inline-start", "20%"); test_valid_value("scroll-padding-inline-start", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-inline-start", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html index 31123d2126f831..5588457b157a09 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-inline", "10px"); test_valid_value("scroll-padding-inline", "20%"); test_valid_value("scroll-padding-inline", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-inline", "calc(50% + 60px)"); test_valid_value("scroll-padding-inline", "1px 2px"); test_valid_value("scroll-padding-inline", "1px auto"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-left-valid.html b/css/css-scroll-snap/parsing/scroll-padding-left-valid.html index 520c9a71208054..15c697ee68cc83 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-left-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-left-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-left", "10px"); test_valid_value("scroll-padding-left", "20%"); test_valid_value("scroll-padding-left", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-left", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-right-valid.html b/css/css-scroll-snap/parsing/scroll-padding-right-valid.html index 4dc461a05e0673..a65473c0eb5d5e 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-right-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-right-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-right", "10px"); test_valid_value("scroll-padding-right", "20%"); test_valid_value("scroll-padding-right", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-right", "calc(50% + 60px)"); diff --git a/css/css-scroll-snap/parsing/scroll-padding-top-valid.html b/css/css-scroll-snap/parsing/scroll-padding-top-valid.html index 566ef06cf32b7a..9644e9b9f5ae94 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-top-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-top-valid.html @@ -16,6 +16,7 @@ test_valid_value("scroll-padding-top", "10px"); test_valid_value("scroll-padding-top", "20%"); test_valid_value("scroll-padding-top", "calc(2em + 3ex)"); +test_valid_value("scroll-padding-top", "calc(50% + 60px)"); From 2b7989baa2dc6fa5216ae664b5679400ab585d78 Mon Sep 17 00:00:00 2001 From: Eric Willigers Date: Fri, 11 Jan 2019 07:16:48 +1100 Subject: [PATCH 3/3] Consolidate scroll-padding parsing tests Consolidate longhand tests into the shorthand parsing test files. --- .../scroll-padding-block-end-valid.html | 22 -------------- .../scroll-padding-block-start-valid.html | 22 -------------- .../parsing/scroll-padding-block-valid.html | 15 +++++++++- .../parsing/scroll-padding-bottom-valid.html | 22 -------------- .../scroll-padding-inline-end-valid.html | 22 -------------- .../scroll-padding-inline-start-valid.html | 22 -------------- .../parsing/scroll-padding-inline-valid.html | 15 +++++++++- .../parsing/scroll-padding-left-valid.html | 22 -------------- .../parsing/scroll-padding-right-valid.html | 22 -------------- .../parsing/scroll-padding-top-valid.html | 22 -------------- .../parsing/scroll-padding-valid.html | 29 ++++++++++++++++++- 11 files changed, 56 insertions(+), 179 deletions(-) delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-bottom-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-left-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-right-valid.html delete mode 100644 css/css-scroll-snap/parsing/scroll-padding-top-valid.html diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html deleted file mode 100644 index 591c155b900089..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-block-end-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-block-end with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html deleted file mode 100644 index 14d211773279fc..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-block-start-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-block-start with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-block-valid.html b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html index c36437c54d5c55..0c495023db8124 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-block-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-block-valid.html @@ -11,8 +11,21 @@ - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html deleted file mode 100644 index 80b73b9f7c9fcd..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-end-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-inline-end with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html deleted file mode 100644 index 8d30485c77eb81..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-start-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-inline-start with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html index 5588457b157a09..60befa1b54e3e0 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-inline-valid.html @@ -11,8 +11,21 @@ - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-right-valid.html b/css/css-scroll-snap/parsing/scroll-padding-right-valid.html deleted file mode 100644 index a65473c0eb5d5e..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-right-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-right with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-top-valid.html b/css/css-scroll-snap/parsing/scroll-padding-top-valid.html deleted file mode 100644 index 9644e9b9f5ae94..00000000000000 --- a/css/css-scroll-snap/parsing/scroll-padding-top-valid.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - -CSS Scroll Snap Test: scroll-padding-top with valid values - - - - - - - - - - diff --git a/css/css-scroll-snap/parsing/scroll-padding-valid.html b/css/css-scroll-snap/parsing/scroll-padding-valid.html index a273ced2f15056..31d71db1b5e64b 100644 --- a/css/css-scroll-snap/parsing/scroll-padding-valid.html +++ b/css/css-scroll-snap/parsing/scroll-padding-valid.html @@ -11,8 +11,35 @@