Add missing comma in earlyoom argument list #18630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in #15724.
jgraham
approved these changes
Aug 23, 2019
|
Oh, Chrome on macOS is acting up: Hardly caused by this change, but triggering all tests on #17217 to see if it's persistent. |
|
#17217 didn't repro the problem, so I'll merge this and assume that was a flaky crash. Haven't seen it before. |
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests#15724.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the comma, the string literals are concatenated.
Spotted via
sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=pythonwith a missing space in Taskcluster logs.
This was introduced in #15724.