From 94765f19e779308fef7fb95280c2cfff7db96c06 Mon Sep 17 00:00:00 2001 From: Miras Myrzakerey Date: Thu, 22 Apr 2021 22:49:40 -0700 Subject: [PATCH] This CL adds functionality that correctly handles network error of Subresource Web Bundles. The problem is: when Web Bundle fetching fails due to a network error, Subresource fetch doesn't fail forever. One such case (subresource-loading-cors-error test) was timing out previously but passes successfully with this change. This CL also adds 2 WPT tests: 1. subresource-loading-network-error.https.tentative.sub.html 2. subresource-loading-web-bundle-fetch-failed.https.tentative.html Test #1 is a scenario with a different network error than the CORS one, but with the same issue of subresource fetching timing out without the change. It passes successfully after the change. Test #2 is a scenario with a Web bundle not found error, which is not directly influenced by the code added in this CL, but it expands the test coverage which was found to be lacking the error cases before. Bug: 1168449 Change-Id: Ia3abb967e36274becc86e317bc51b1272d3ae679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826001 Reviewed-by: Tsuyoshi Horo Reviewed-by: Hayato Ito Reviewed-by: Kinuko Yasuda Commit-Queue: Miras Myrzakerey Cr-Commit-Position: refs/heads/master@{#875532} --- ...ing-network-error.https.tentative.sub.html | 31 +++++++++++++++++ ...g-webbundle-not-found.https.tentative.html | 33 +++++++++++++++++++ 2 files changed, 64 insertions(+) create mode 100644 web-bundle/subresource-loading/subresource-loading-network-error.https.tentative.sub.html create mode 100644 web-bundle/subresource-loading/subresource-loading-webbundle-not-found.https.tentative.html diff --git a/web-bundle/subresource-loading/subresource-loading-network-error.https.tentative.sub.html b/web-bundle/subresource-loading/subresource-loading-network-error.https.tentative.sub.html new file mode 100644 index 00000000000000..23e71409b849fd --- /dev/null +++ b/web-bundle/subresource-loading/subresource-loading-network-error.https.tentative.sub.html @@ -0,0 +1,31 @@ + +Web Bundle fetching failed due to a network error + + + + + + + + + diff --git a/web-bundle/subresource-loading/subresource-loading-webbundle-not-found.https.tentative.html b/web-bundle/subresource-loading/subresource-loading-webbundle-not-found.https.tentative.html new file mode 100644 index 00000000000000..d54ffe095f17d6 --- /dev/null +++ b/web-bundle/subresource-loading/subresource-loading-webbundle-not-found.https.tentative.html @@ -0,0 +1,33 @@ + +Web Bundle fetching failed due to not found error + + + + + + + + +