Skip to content

Releases: web-platform-tests/wpt

merge_pr_48546

14 Oct 06:48
Compare
Choose a tag to compare

Use selection focus for caret position while navigating using arrow keys

While moving cursor up and down, the cursor should come exactly above
and below the previous position respectively. Currently the cursor
position is not correct in these scenarios since we pass
|selection_.Start()| to calculate the x position while editing, instead
we should pass |selection_.Focus()| since focus will be having the last
position of the caret. This change is Firefox compatible.

Updated some existing web_tests that were using selection modifier and
after this CL, the caret position is now changed so these web_tests
needed to adhere to the updated caret positioning.

Updated tests:
web_tests/editing/pasteboard/paste-list-002.html
web_tests/editing/pasteboard/paste-list-003.html
web_tests/editing/pasteboard/paste-list-004.html
web_tests/editing/selection/move-3875618-fix.html
web_tests/editing/inserting/insert-3786362-fix-expected.txt

Bug: 40658856
Change-Id: Id6f00889621003072d7f88bcc00d10f8318ad8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804495
Reviewed-by: Siye Liu siliu@microsoft.com
Reviewed-by: Kent Tamura tkent@chromium.org
Commit-Queue: Utkarsh Pathak utpathak@microsoft.com
Reviewed-by: Sanket Joshi sajos@microsoft.com
Cr-Commit-Position: refs/heads/main@{#1368113}

merge_pr_48498

14 Oct 19:59
Compare
Choose a tag to compare

Don't convert intermediate relative colors out of legacy RGB

Converting from ColorSpace::kSRGBLegacy to ColorSpace::kSRGB translates
none values to zero, which is desirable in a final result but gives
incorrect results when done to a relative color which is the input for
another color function. Defer the conversion until we're at a top-level
call to resolve a color.

Public APIs on StyleColor and inner classes are reshaped a bit to
ensure the conversion happens when needed and doesn't happen when it
shouldn't.

Bug: 365818844
Change-Id: If748a639a852ef7703c4b6a2ff6a43cddfb8cbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5851564
Reviewed-by: David Baron dbaron@chromium.org
Commit-Queue: Kevin Babbitt kbabbitt@microsoft.com
Reviewed-by: Fredrik Söderquist fs@opera.com
Cr-Commit-Position: refs/heads/main@{#1368377}

merge_pr_48583

12 Oct 09:56
Compare
Choose a tag to compare

Make HTMLEditor::InsertElementAtSelectionAsAction split ancestor inline elements

Chrome and Safari splits ancestors when document.execCommand("insertImage")
inserts an <img>, but we insert into the closest inline element. For example,

<b>A[]B</b>

Chrome and Safari make it to:

<b>A</b><img><b>B</b>

But Firefox makes it to:

<b>A<img>B</b>

I think that we should not change the behavior on Thunderbird. Therefore, the
behavior is controlled with the new options argument and the new behavior
runs only when the HTMLEditor works for content document and it's not caused
by the XPCOM method.

Differential Revision: https://phabricator.services.mozilla.com/D225037

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1923250
gecko-commit: 4d82c0995e5d5653017d08b4c101f078a165039c
gecko-reviewers: m_kato

merge_pr_48579

12 Oct 00:43
Compare
Choose a tag to compare

[fenced-frames] Migrate WebAuthn test

Migrate a fenced frames WebAuthn test to run on headless chrome with
chromedriver instead of the legacy content shell runner. The legacy
content shell runner will stop supporting the WebAuthn testdriver API,
soon.

Fix the test to set up the virtual authenticator environment on the top
frame instead, since testdriver should be invoked from the same window
hosting the testharness.

Bug: 372169469
Change-Id: I6e1b296fe86ee4087da2a5a63868e18a6b440984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5920770
Auto-Submit: Nina Satragno nsatragno@chromium.org
Reviewed-by: Liam Brady lbrady@google.com
Commit-Queue: Liam Brady lbrady@google.com
Cr-Commit-Position: refs/heads/main@{#1367535}

merge_pr_48558

12 Oct 10:02
Compare
Choose a tag to compare

Adjust fuzzy annotations etc for testcases affected by disabling the forced-gdi-classic rendering pref.

Differential Revision: https://phabricator.services.mozilla.com/D225074

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920733
gecko-commit: 250b53008ebe9fa6069de67ebe7af58abfab67b7
gecko-reviewers: gfx-reviewers, lsalzman

merge_pr_48582

11 Oct 22:16
280d04e
Compare
Choose a tag to compare

[wptrunner] Cycle testdriver event loop when testharness isn't loaded (#48582)

Workaround for https://crbug.com/340662810 that seems to work
without an increase in test runtime or regressions
(https://crrev.com/c/5698330/9).

merge_pr_48581

11 Oct 20:32
Compare
Choose a tag to compare

Rename & refactor invoker commands to reflect new spec decisions.

Invoker commands now live solely on HTMLButtonElement, and have been
dropped from HTMLInputElement. This was discussed and resolved + minuted
in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

Words must be separated with dashes. This was discussed and resolved +
minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

"Custom" commands now require a double dash (--) prefix. This was
discussed & resolved + minuted in the Jul 25 OpenUI meeting:
openui/open-ui#969 (comment)

In addition, CommandEvent#invoker is now renamed to CommandEvent#source
as discussed and resolved + minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

This CL updates the tests & implementation to follow these changes. The
changes can also be found in the spec PR which reflects this updated
status:

whatwg/html#9841

Bug: 40284894
Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601
Reviewed-by: Mason Freed masonf@chromium.org
Reviewed-by: Luke lwarlow@igalia.com
Commit-Queue: Keith Cirkel chromium@keithcirkel.co.uk
Cr-Commit-Position: refs/heads/main@{#1367705}

merge_pr_48580

11 Oct 18:57
Compare
Choose a tag to compare

Add implicit anchor relationship for popover invokers

When PopoverAnchorRelationships is enabled, include popover invokers
as "implicit anchor elements" for anchor positioning.

This also adds a test of the behavior when nesting within other top layer elements, and vice versa. Bug: 364669918 Change-Id: Ie1d362a41e3aec72d62dbfe378e65ea9a262c324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846489 Auto-Submit: Mason Freed masonf@chromium.org Commit-Queue: Joey Arhar jarhar@chromium.org Reviewed-by: Joey Arhar jarhar@chromium.org Cr-Commit-Position: refs/heads/main@{#1367631}

merge_pr_48577

11 Oct 16:24
Compare
Choose a tag to compare

Shadow trees: more involved dispatch tests

In particular, this adds tests for when the target get moved out of the shadow tree or into a shadow tree by an event listener.

Co-authored-by: Chris Dumez cdumez@apple.com

merge_pr_48576

11 Oct 15:30
1fc69a2
Compare
Choose a tag to compare

Sync interfaces/ with @webref/idl 3.55.2 (#48576)

Co-authored-by: wpt-pr-bot wpt-pr-bot@users.noreply.github.com