fix: revert "feat: upload-client funcs have options.piece to opt in to piece link calculation (#1220) #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
changed the title
alanshaw
approved these changes
Dec 7, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [12.3.1](upload-client-v12.3.0...upload-client-v12.3.1) (2023-12-07) ### Fixes * revert "feat: upload-client funcs have options.piece to opt in to piece link calculation ([#1220](#1220)) ([#1224](#1224)) ([2f238bf](2f238bf)) * upgrade fr32-sha2-256-trunc-254-padded-binary-tree-multihash to 3.1.1. ([#1223](#1223)) ([0801d90](0801d90)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c38000e.
Needs #1223 merged.
Alternatively, we can keep the code as is and make the default true. However, I feel that our current way of making computation in the client and not do Bucket events would go against supporting this as optional