Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cron jobs package test setup #1113

Closed
flea89 opened this issue Mar 16, 2022 · 0 comments · Fixed by #1148
Closed

Update cron jobs package test setup #1113

flea89 opened this issue Mar 16, 2022 · 0 comments · Fixed by #1148
Assignees
@flea89
Labels
P2 Medium: Good to have, but can wait until someone steps up stack/quality-velocity topic/devexp Developer experience improvements, onboard efficiencies, time savers. topic/pot Issues handled by PT.

Comments

@flea89
Copy link
Contributor

flea89 commented Mar 16, 2022 •
edited
Loading

The cron/package is still using smoke to mock PostRest and Cluster. With all the challenges that comes with it.

We should be using dockerised instances of both instead and match the behavior in the api package.
@mbommerez mbommerez added P2 Medium: Good to have, but can wait until someone steps up topic/devexp Developer experience improvements, onboard efficiencies, time savers. topic/pot Issues handled by PT. labels Mar 17, 2022
@flea89 flea89 mentioned this issue Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flea89 flea89

Labels
P2 Medium: Good to have, but can wait until someone steps up stack/quality-velocity topic/devexp Developer experience improvements, onboard efficiencies, time savers. topic/pot Issues handled by PT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move dockerized services in cron tests web3-storage/web3.storage
3 participants
@flea89 @dchoi27 @mbommerez