Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: faster pin status sync #338

Merged
merged 1 commit into from
Aug 11, 2021
Merged

perf: faster pin status sync #338

merged 1 commit into from
Aug 11, 2021

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Aug 11, 2021

This reduces the time taken to update pin statuses for 1,000 pins from ~15m to ~5s.

Status requests from cluster are super quick, but DB requests are slower. This switches to using a bulk update UDF, called once per 1,000 pins.

resolves #273

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great

@alanshaw alanshaw merged commit 2861e33 into main Aug 11, 2021
@alanshaw alanshaw deleted the perf/faster-pin-status-sync branch August 11, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faster pin cron
2 participants