Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing user uploads could be faster #61

Closed
andrew opened this issue Jul 12, 2021 · 4 comments · Fixed by #1466
Closed

Listing user uploads could be faster #61

andrew opened this issue Jul 12, 2021 · 4 comments · Fixed by #1466
Assignees
@drewdelano
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website

Comments

@andrew
Copy link

andrew commented Jul 12, 2021 •
edited by JeffLowe
Loading

The endpoint listing user uploads seems to be a little slow, could be because of the pagination options passed causing missed indexes perhaps?

Url: https://api-staging.web3.storage/user/uploads?before=2021-07-12T13%3A26%3A44.976Z&size=25
Number of files listed in response: 1
Avg time to load in firefox: ~1 second

Related to performance research in #94
@olizilla olizilla mentioned this issue Jul 15, 2021
Open
@dchoi27 dchoi27 added the kind/bug A bug in existing code (including security flaws) label Aug 1, 2021
@dchoi27 dchoi27 added the P2 Medium: Good to have, but can wait until someone steps up label Aug 26, 2021
@vasco-santos
Copy link
Contributor

We moved to Postgres and this should not be the case anymore. Closing this, but feel free to reopen if this is still a problem

@andrew
Copy link
Author

andrew commented Nov 29, 2021

It's actually much worse for my account now:

$ time curl -H 'Accept: application/json' -H "Authorization: Bearer TOKEN" https://api.web3.storage/user/uploads
$ [jsonresultshere]
real	0m7.084s
user	0m0.022s
sys	0m0.010s

@andrew andrew reopened this Nov 29, 2021
@dchoi27 dchoi27 added the topic/pot Issues handled by PT. label Jan 21, 2022
@orvn
Copy link
Contributor

orvn commented May 19, 2022

@dchoi27 I think this might be mislabeled/an issue outside of stack/website?

(On the frontend, #1341 should help with displaying the list more quickly, but that's not directly related to this issue)

@JeffLowe JeffLowe added potential/websites-pi work to package into upcoming websites initiative pi/dotstorage-site-improvements Improvements to web3 and nft websites and removed topic/pot Issues handled by PT. potential/websites-pi work to package into upcoming websites initiative labels May 30, 2022
@drewdelano drewdelano linked a pull request Jun 13, 2022 that will close this issue
fix: naive take on adding an index #1466
Merged
@drewdelano
Copy link
Contributor

I think this a missing index issue

@JeffLowe JeffLowe mentioned this issue Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewdelano drewdelano

Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: naive take on adding an index web3-storage/web3.storage
7 participants
@andrew @johnathonroach @JeffLowe @orvn @vasco-santos @dchoi27 @drewdelano