Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include minified assets in npm release #2015

Closed
fulldecent opened this issue Oct 21, 2018 · 3 comments
Closed

Include minified assets in npm release #2015

fulldecent opened this issue Oct 21, 2018 · 3 comments

Comments

@fulldecent
Copy link

Currently, npm releases include only index.js. Additionally, or alternatively, they should include a minified file. This has security implications

Security impact

CDNs like JSDelivr see non-minified files as suboptimal and they transpile them into minified versions before delivery. This is a proprietary and non-repeatable process.

For business reasons, JSDeliver will not support SRI for transpiled assets. Source: jsdelivr/jsdelivr#18105 (comment)

Currently, the build process is not auditable and security is not optimized because SRI is not available with the current distribution strategy.

Reference

Latest npm release: https://www.npmjs.com/package/web3/v/1.0.0-beta.36

I don't know how to properly cite the file tree. But I installed it and made a screenshot.

screen shot 2018-10-21 at 7 07 19 pm

@fulldecent
Copy link
Author

Maybe this is duplicate or maybe GitHub is showing me errors for no reason today.

@fulldecent
Copy link
Author

Yup GitHub is down https://status.github.com/messages

@fulldecent
Copy link
Author

Duplicate of #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant