Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate set registry functions from 1.x for 4.x rewrite #4552

Closed
luu-alex opened this issue Nov 17, 2021 · 2 comments
Closed

Migrate set registry functions from 1.x for 4.x rewrite #4552

luu-alex opened this issue Nov 17, 2021 · 2 comments
Assignees
@jdevcs
Labels
4.x 4.0 related

Comments

@luu-alex
Copy link
Contributor

luu-alex commented Nov 17, 2021 •
edited
Loading

Description

Migrate the following functions from web3-eth-ens contract functions for registry 1.x branch to 4.x rewrite.

  • setOwner
  • setTTL
  • setSubnodeOwner
  • setRecord
  • setSubnodeRecord
  • setApprovalForAll
  • setResolver

Deprecated functions from 1.x

  • resolver
  • owner

Acceptance Criteria

  • All functions above should be migrated
  • All functions should be covered with unit tests

Links and resources
@luu-alex luu-alex added the 4.x 4.0 related label Nov 17, 2021
@luu-alex luu-alex mentioned this issue Nov 17, 2021
Closed
4 tasks
@mconnelly8
Copy link

Hey team! Please add your planning poker estimate with ZenHub @jdevcs @luu-alex @nazarhussain @spacesailor24

@luu-alex luu-alex changed the title Migrate registry functions from 1.x Migrate set registry functions from 1.x for 4.x rewrite Dec 6, 2021
@jdevcs
Copy link
Contributor

jdevcs commented Feb 14, 2022

these function (except setRecord) added in PR 4762

@jdevcs jdevcs mentioned this issue Feb 24, 2022
Merged
16 tasks
@luu-alex luu-alex closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdevcs jdevcs

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luu-alex @jdevcs @mconnelly8