Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped tests after libs updates in 1.x #5752

Closed
2 tasks done
nikoulai opened this issue Jan 12, 2023 · 0 comments
Closed
2 tasks done

Fix skipped tests after libs updates in 1.x #5752

nikoulai opened this issue Jan 12, 2023 · 0 comments
Assignees
Labels
1.x 1.0 related issues

Comments

@nikoulai
Copy link
Contributor

This is not a Bug Report, Feature Request, or related to Documentation

  • I have searched the existing issues

Is there an existing issue for this?

  • I have searched the existing issues

What's up?

After the change from ganache-cli to ganache in 1.x (#5671), some tests started failing and are skipped currently.

Investigate what's going on and fix.

Examples/References

One of them is queues requests made while connection is lost / executes on reconnect in web3.js/test/websocket.ganache.js, which wants to test that the ws reconnects, closes temporarily. Ganache's close function uses code 1000, so it closes smoothly. My guess is that for this reason web3.js doesn't try to reconnect.

https://github.com/trufflesuite/ganache/blob/7ee7d4b78b892a52940369e61ff1b6ad6b670771/src/packages/core/src/servers/ws-server.ts#L195
https://github.com/trufflesuite/ganache/blob/develop/src/packages/core/src/servers/utils/websocket-close-codes.ts

@nikoulai nikoulai added the 1.x 1.0 related issues label Jan 12, 2023
@luu-alex luu-alex removed the Estimate label Jan 24, 2023
@luu-alex luu-alex self-assigned this Jan 24, 2023
@jdevcs jdevcs mentioned this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

No branches or pull requests

3 participants