Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP Workflow on Windows #86

Closed
dokempf opened this issue Jul 20, 2021 · 1 comment
Closed

SCP Workflow on Windows #86

dokempf opened this issue Jul 20, 2021 · 1 comment

Comments

@dokempf
Copy link

dokempf commented Jul 20, 2021

Thanks for providing this action, I am a very happy user!

I have recently stumbled across an issue on Windows with one of my use cases: I am using the action to set up a private key, which I then use to copy large, non-public files with scp from a VM hosted at my institution to the GitHub runner. The workflow works fine on Linux. On Windows, the action itself is successful, but the scp operation in a subsequent step fails with Permission denied (publickey)..

After reading carefully through #63 I was able to actually fix the problem by replacing my plain usage of scp on Windows with c://progra~1//git//usr//bin//scp.exe. I am happy to have found this fix, but I really do not like it. I would prefer it if this action could modify the environment such that the correct versions of SSH-related executables are picked up. I can imagine this in both an implicit way (like modifying path variables) or an explicit way (like export e.g. an SCP_BIN environment variable for the user to use).

Feel free to ignore and close this if you consider it out of scope of the action.

@mpdude
Copy link
Member

mpdude commented Jul 28, 2021

I was trying to focus the action on setting up the SSH Agent, so I am a bit reluctant to do more than strictly necessary. After all, all that needs to be maintained and fixed for various platforms in the long run.

I would, however, very much welcome a PR that adds a short problem explanation and possible workaround to the https://github.com/webfactory/ssh-agent#additional-information-for-particular-tools-or-platforms section of the README.

Would you want to do that?

@mpdude mpdude closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants