fix: do not break selector with escaping #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 99.47% 99.23% -0.25%
==========================================
Files 10 10
Lines 381 391 +10
Branches 109 114 +5
==========================================
+ Hits 379 388 +9
- Misses 2 3 +1
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
fix-do-not-break-selector-with-escaping
branch
from
fc6f1b3 to
acfe183
Compare
alexander-akait
commented
Mar 4, 2019
| \\"3A\\": \\"_2CroCHBxlB1qbFlcySSx5w\\", | ||
| \\"#fake-id\\": \\"_2E85FJStrx25rDG2lYWifC\\", | ||
| \\":\`(\\": \\"_4_pn9LmAb2XtAy0kg4FN_\\", | ||
| \\"1a2b3c\\": \\"_2LEttkwzH7jRE93Ku8MGqY\\", |
alexander-akait
commented
Mar 4, 2019
| \\"class\\": \\"_1PSZ4tK4URrenXyNSoawrx\\", | ||
| \\"class-duplicate-url\\": \\"_3YYoEr128Gk7ZgfRycu4tr\\", | ||
| \\"two\\": \\"_1LWD9ZV4XMmN23IPiMONS3\\", | ||
| \\"u-m+\\": \\"_3i3CD1fyX8bvzRt1H0IV-f\\", | ||
| \\"-top\\": \\"_1fWEySWrY44TvDnJ8JNxnE\\", | ||
| \\"#test\\": \\"Zmuw5k7Gg4hpgd6CVBEkq\\", | ||
| \\"\\\\\\\\\\": \\"_3UVS-Zs6Sa7sP9yLR2EN58\\", | ||
| \\"test\\": \\"_2mQhIWfQwYBHR8C-27Rb-E\\", |
There was a problem hiding this comment.
ID selectors still broken, WIP on this
|
Problem in :local(#\#fake-id) {
color: red;
}https://codepen.io/anon/pen/qvNzja?&editable=true (example with not) |
alexander-akait
force-pushed
the
fix-do-not-break-selector-with-escaping
branch
from
acfe183 to
9e29b69
Compare
alexander-akait
force-pushed
the
fix-do-not-break-selector-with-escaping
branch
from
9e29b69 to
3aab2ef
Compare
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fix escaping in selectors
fixes #578
Breaking Changes
No
Additional Info
/cc @jquense Looks like all tests good, except some selectors we need fix before merge
postcss/postcss-selector-parser#174
postcss/postcss-selector-parser#175