Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed cjs wrapper #152

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Apr 29, 2022

Resolve #140

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but now we use invalid format our types

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #152 (71b7c90) into master (08af5d6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #152   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         7    -1     
  Lines          252       273   +21     
  Branches        73        75    +2     
=========================================
+ Hits           252       273   +21     
Impacted Files Coverage Δ
src/ESLintError.js 100.00% <100.00%> (ø)
src/getESLint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)
src/options.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08af5d6...71b7c90. Read the comment docs.

@alexander-akait
Copy link
Member

@ricardogobbosouza I think we can merge and do release here

@ricardogobbosouza
Copy link
Collaborator Author

@alexander-akait I'll do it

@ricardogobbosouza ricardogobbosouza merged commit 125becf into master Jun 18, 2022
@ricardogobbosouza ricardogobbosouza deleted the feat-remove-cjs-wrapper branch June 18, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants