Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompile speedups #55

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Recompile speedups #55

merged 3 commits into from
Nov 30, 2020

Conversation

jsg2021
Copy link
Contributor

@jsg2021 jsg2021 commented Nov 30, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Speed up recompiles by only using threads for the initial run.

Breaking Changes

Additional Info

Fixes #52

@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #55 (fddb89d) into master (bdb5210) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          219       239   +20     
  Branches        59        65    +6     
=========================================
+ Hits           219       239   +20
Impacted Files Coverage Δ
src/options.js 100.00% <ø> (ø)
src/getESLint.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb5210...71ac229. Read the comment docs.

@jsg2021 jsg2021 mentioned this pull request Nov 30, 2020
Closed
@jsg2021
Copy link
Contributor Author

jsg2021 commented Nov 30, 2020

The action probably just needs re-run. The failure looks like a transient network failure

ricardogobbosouza
ricardogobbosouza requested changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to document this option threads in the readme

src/options.js Outdated Show resolved Hide resolved
@ricardogobbosouza ricardogobbosouza merged commit d862d92 into webpack-contrib:master Nov 30, 2020
@ricardogobbosouza
Copy link
Collaborator

Thanks @jsg2021

@johannescpk johannescpk mentioned this pull request Dec 1, 2020
Merged
@fangbinwei fangbinwei mentioned this pull request Dec 1, 2020
Closed
@jsg2021 jsg2021 deleted the threaded-speedups branch April 7, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardogobbosouza ricardogobbosouza ricardogobbosouza requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threads massively slows down linting / re-linting
2 participants
@jsg2021 @ricardogobbosouza