Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SASS modules - @use #766

Closed
donnysim opened this issue Oct 3, 2019 · 6 comments
Closed

Add support for SASS modules - @use #766

donnysim opened this issue Oct 3, 2019 · 6 comments

Comments

@donnysim
Copy link
Contributor

donnysim commented Oct 3, 2019

  • Operating System: -
  • Node Version: -
  • NPM Version: -
  • webpack Version: -
  • sass-loader Version: -

Feature Proposal

While @use is new and libsass, ruby sass does not support it yet, you can fully use it with dart sass, so it would be awesome if it could track imports from @use statements and trigger watchers.

Feature Use Case

http://sass.logdown.com/posts/7858341-the-module-system-is-launched

@donnysim
Copy link
Contributor Author

donnysim commented Oct 4, 2019

Might've been my bad, it does seem to track @use imports.

@donnysim donnysim closed this as completed Oct 4, 2019
@alexander-akait
Copy link
Member

@donnysim use already supported?

@donnysim
Copy link
Contributor Author

donnysim commented Oct 4, 2019

@evilebottnawi using it with dart sass 1.23.0 and everything works, it tracks dependencies etc. just fine. I thought it didn't work, but I just messed up the use path to the wrong file so it didn't track the correct file for changes. Haven't tried it with node_modules but don't really have anything requiring it atm..

@alexander-akait
Copy link
Member

@donnysim thanks for feedback, will be great if we add tests for @use, you can help 😄

@donnysim
Copy link
Contributor Author

donnysim commented Oct 4, 2019

I'm not sure what would be the way to add a test when only dart sass supports it for the time being.

@alexander-akait
Copy link
Member

Just add tests only for dart sass 😄

@Simek Simek mentioned this issue Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants