You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Source maps should be parsed correctly and mappings should be included for all files that have sourcesContent or for which sources points to a valid file (even if there are some sources for which the values are invalid/missing).
Actual Behavior
source maps generated with the Google Closure compiler are not parsed at all.
This is because they contain some sources which are not present on the filesystem, and/or "sources" like " [synthetic:es6/util/arrayiterator] ". See google/closure-compiler-js#25
Failed to parse source map from 'node_modules/shaka-player/node_modules/google-closure-library/closure/goog/base.js' file: Error: ENOENT: no such file or directory, open 'node_modules/shaka-player/node_modules/google-closure-library/closure/goog/base.js'
Failed to parse source map from 'node_modules/shaka-player/dist/ [synthetic:util/global] ' file: Error: ENOENT: no such file or directory, open 'node_modules/shaka-player/dist/ [synthetic:util/global] '
Obviously the mappings referring to these source files will not work because they are not present, but the other mappings for files that are present should still work.
even if there are some sources for which the values are invalid/missing
No, source maps will be broken in this case, even we provide options to filter you still have invalid mapping, library source maps should not contain this stuff
Expected Behavior
Source maps should be parsed correctly and mappings should be included for all files that have
sourcesContent
or for whichsources
points to a valid file (even if there are some sources for which the values are invalid/missing).Actual Behavior
source maps generated with the Google Closure compiler are not parsed at all.
This is because they contain some sources which are not present on the filesystem, and/or "sources" like
" [synthetic:es6/util/arrayiterator] "
. See google/closure-compiler-js#25Obviously the mappings referring to these source files will not work because they are not present, but the other mappings for files that are present should still work.
How Do We Reproduce?
Applying
source-map-loader
to the latest build of https://github.com/google/shaka-player triggers the error.The text was updated successfully, but these errors were encountered: