Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5's "getOptions" is missing #106

Closed
ef4 opened this issue Dec 8, 2020 · 8 comments · Fixed by #113
Closed

Webpack 5's "getOptions" is missing #106

ef4 opened this issue Dec 8, 2020 · 8 comments · Fixed by #113

Comments

@ef4
Copy link

ef4 commented Dec 8, 2020

Expected Behavior

Loaders that use webpack 5's this.getOptions() API should work with thread-loader.

See webpack/webpack#10017

Actual Behavior

this.getOptions is undefined.

How Do We Reproduce?

Pick any loader that uses getOptions from loader-utils and modify it to use this.getOptions instead. That works when using webpack 5 without thread-loader, but fails when used behind thread-loader.

@alexander-akait
Copy link
Member

PR welcome

@irfan-maulana-tkp
Copy link

@ccabrales
Copy link

Anybody know how to go about fixing this?

@alexander-akait
Copy link
Member

@qnighy Can you help with this, because we need fix compatibility with webpack v5 before release

@qnighy
Copy link
Contributor

qnighy commented Apr 10, 2021

@alexander-akait sure, I'll try to reproduce and fix it this weekend.

@qnighy
Copy link
Contributor

qnighy commented Apr 10, 2021

Reproduction: https://github.com/qnighy/thread-loader-issue-106

@qnighy
Copy link
Contributor

qnighy commented Apr 10, 2021

It also reproduces with sass-loader@11 so I'm going to update the devDependency in thread-loader and fix the test failure.

@qnighy
Copy link
Contributor

qnighy commented Apr 10, 2021

Created a fix #113 though it's not an optimal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants