-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 5's "getOptions" is missing #106
Comments
PR welcome |
Adding the Docs: https://webpack.js.org/migrate/5/#getoptions-method-for-loaders |
Anybody know how to go about fixing this? |
@qnighy Can you help with this, because we need fix compatibility with webpack v5 before release |
@alexander-akait sure, I'll try to reproduce and fix it this weekend. |
Reproduction: https://github.com/qnighy/thread-loader-issue-106 |
It also reproduces with |
Created a fix #113 though it's not an optimal solution. |
Expected Behavior
Loaders that use webpack 5's
this.getOptions()
API should work with thread-loader.See webpack/webpack#10017
Actual Behavior
this.getOptions
is undefined.How Do We Reproduce?
Pick any loader that uses
getOptions
fromloader-utils
and modify it to usethis.getOptions
instead. That works when using webpack 5 without thread-loader, but fails when used behind thread-loader.The text was updated successfully, but these errors were encountered: