This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 158
v1.1.0 options.name is failure #138
Comments
I think it's because v1.0.1 used to do this, so const fallback = require(options.fallback ? options.fallback : 'file-loader');
return fallback.call(this, src); Here's a failing test for test('{undefined}', async () => {
const config = {
loader: {
test: /\.png$/,
options: {
limit: 100,
name: 'name-for-url-loader.[ext]',
},
},
};
const stats = await webpack('fixture.js', config);
const { source } = stats.toJson().modules[0];
expect(source).toMatchSnapshot();
}); For this not to be a breaking release, would it need to support passing along all the options |
Merged
6 tasks
this is a big bug |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is my configuration file
This is the generated file
v1.0.1 is ok
The text was updated successfully, but these errors were encountered: