Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

fix: allow use limit as {String} #96

Merged
merged 1 commit into from
Oct 4, 2017
Merged

fix: allow use limit as {String} #96

merged 1 commit into from
Oct 4, 2017

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 4, 2017 •
edited by michael-ciniawsky
Loading

@alexander-akait alexander-akait mentioned this pull request Oct 4, 2017
Closed
@alexander-akait alexander-akait added this to the 0.6.2 milestone Oct 4, 2017
@damonbauer
Copy link

FWIW it looks like loader-utils does not parse numbers:

?xyz=1 -> { xyz: "1" } // numbers are NOT parsed

https://github.com/webpack/loader-utils#parsequery

@alexander-akait
Copy link
Member Author

@damonbauer we use https://github.com/webpack-contrib/url-loader/blob/master/index.js#L20 if it is string

@michael-ciniawsky michael-ciniawsky changed the title fix: allow use limit as string fix: allow use limit as {String} Oct 4, 2017
@michael-ciniawsky michael-ciniawsky modified the milestones: 0.6.2, 0.6.1 Oct 4, 2017
@joshwiens joshwiens merged commit b31684d into master Oct 4, 2017
@joshwiens joshwiens deleted the fix-95 branch October 4, 2017 17:57
@michael-ciniawsky michael-ciniawsky removed this from the 0.6.3 milestone Oct 4, 2017
This was referenced Oct 4, 2017
Merged
Merged
Merged
@dependencies dependencies bot mentioned this pull request Dec 5, 2017
Merged
This was referenced Mar 21, 2018
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 13, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Mar 2, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
This was referenced Apr 24, 2020
Open
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshwiens joshwiens joshwiens approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Assignees
No one assigned
Labels
semver: Patch status: Approved type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexander-akait @damonbauer @michael-ciniawsky @joshwiens