This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
feat: support loading node core modules #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joshwiens
changed the title
|
Thanks @FrogTheFrog |
michael-ciniawsky
changed the title
|
@TrySound 2 simple tests added. One for dependencies that should be missing (when target is |
|
Nice |
TrySound
approved these changes
Jul 4, 2017
|
@TrySound I decided to actually add tests for all targets instead of assuming that it should work. |
|
Good |
joshwiens
approved these changes
Jul 4, 2017
joshwiens
added
pr_action: Merge ready
and removed
flag: Needs Tests
pr_action: Review
labels
`this.options` is deprecated so why not?
joshwiens
pushed a commit
that referenced
this pull request
Sep 25, 2017
* Allow worker-loader to load node core modules * added tests for all targets * change this.options.target to this.target
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
* Allow worker-loader to load node core modules * added tests for all targets * change this.options.target to this.target
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should no longer throw errors for missing node modules, such as
fs,pathand etc.It applies
NodeTargetPluginto child compiler if the main target usesNodeTargetPlugin. Every target apart fromwebworkerandwebuseNodeTargetPlugin.Fixes #44, #55