feat: add option to change the filename #51
Conversation
|
|
index.js
Outdated
| @@ -11,6 +11,7 @@ function CompressionPlugin(options) { | |||
| options = options || {}; | |||
| this.asset = options.asset || "[path].gz[query]"; | |||
| this.algorithm = options.algorithm || "gzip"; | |||
| this.changeNewFileName = options.changeNewFileName || false; | |||
There was a problem hiding this comment.
this.changeNewFileName => this.name or something that is similiar terse 😛
There was a problem hiding this comment.
See how we did something similar in extract-text-webpack-plugin. Maybe a good solution to mimic.
There was a problem hiding this comment.
@ronen-e please see https://github.com/webpack-contrib/extract-text-webpack-plugin#options (options.filename)
There was a problem hiding this comment.
@michael-ciniawsky I didn't see any tests for the existing code.
I would like to add to them if they exist.
Do you have any tests that you already run on the code?
There was a problem hiding this comment.
Ah, yeah... We would have to update this project to webpack-defaults to get testing infrastructure in place.
There was a problem hiding this comment.
@ronen-e Ooops.. 😛 forget what I said then 🙃 Just change tofilename + docs and good to go imho
michael-ciniawsky
changed the title
Optionally change file name