Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-uri (issue #38) #58

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Fix data-uri (issue #38) #58

merged 1 commit into from
Nov 23, 2015

Conversation

next0
Copy link
Contributor

@next0 next0 commented Sep 28, 2015

Fix issue #38 :

Module build failed: error evaluating function `data-uri`: Cannot 'resolveSync' because the fileSystem is not sync. Use 'resolve'!

@next0
Fix issue webpack-contrib#38
6bb1d96 
```
Module build failed: error evaluating function `data-uri`: Cannot 'resolveSync' because the fileSystem is not sync. Use 'resolve'!
```
@ericmatthys
Copy link

This fixes the data-uri issue in my project. 👍

@next0 next0 mentioned this pull request Oct 20, 2015
Closed
@revolunet
Copy link

yes please :)

@XiXora
Copy link

XiXora commented Nov 4, 2015

+1

2 similar comments
@jeantroiani
Copy link

+1

@andresgarza
Copy link

+1

@ftdebugger
Copy link

Merge please

@criyology
Copy link

+1

10 similar comments
@vlyahovich
Copy link

+1

@antejan
Copy link

antejan commented Nov 18, 2015

+1

@roman-mazhut
Copy link

+1

@NeXidan
Copy link

NeXidan commented Nov 18, 2015

👍

@DenisHomich
Copy link

+1

@dontuncleme
Copy link

+1

@Tocher
Copy link

Tocher commented Nov 18, 2015

👍

@lifus
Copy link

lifus commented Nov 18, 2015

+1

@nchereva
Copy link

👍

@dorsha
Copy link

dorsha commented Nov 19, 2015

+1

sokra added a commit that referenced this pull request Nov 23, 2015
@sokra
Merge pull request #58 from next0/master
fdda45b 
Fix data-uri (issue #38)
@sokra sokra merged commit fdda45b into webpack-contrib:master Nov 23, 2015
@sokra
Copy link
Member

sokra commented Nov 23, 2015

Thanks

@revolunet
Copy link

thanks

@jhnns
Copy link
Member

jhnns commented Nov 25, 2015

@next0 Awesome! You've even included tests 👍

@jhnns
Copy link
Member

jhnns commented Nov 25, 2015

Fix shipped with 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.