Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smart not case #101

Merged
merged 1 commit into from
May 18, 2020
Merged

feat: smart not case #101

merged 1 commit into from
May 18, 2020

Conversation

vankop
Copy link
Member

@vankop vankop commented May 18, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

finish #61

#42
part of 1st proposal.

Breaking Changes

No

Additional Info

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #101 into master will decrease coverage by 0.37%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   97.95%   97.57%   -0.38%     
==========================================
  Files           6        6              
  Lines         683      700      +17     
  Branches      284      299      +15     
==========================================
+ Hits          669      683      +14     
- Misses         13       15       +2     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/ValidationError.js 96.69% <89.65%> (-0.70%) ⬇️
src/util/hints.js 100.00% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36e535...8a688e7. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants