Don't add charset to certain file types #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpoitch
requested review from
alexander-akait and
michael-ciniawsky
as code owners
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 96.82% 96.83% +0.01%
==========================================
Files 7 7
Lines 252 253 +1
==========================================
+ Hits 244 245 +1
Misses 8 8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 96.83% 96.85% +0.01%
==========================================
Files 7 7
Lines 253 254 +1
==========================================
+ Hits 245 246 +1
Misses 8 8
Continue to review full report at Codecov.
|
|
Previous PR was right, just need major release for this, but this we can merge as bugfix, please reopen old PR for future major release, thanks |
alexander-akait
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix. #350
Less aggressive alternative to PR #351
Did you add tests for your changes?
Yes
Summary
Creates a variable to special case more file types that should not automatically have a charset added to their content-type header. This was already the case for wasm and this also adds usdz.
Does this PR introduce a breaking change?
No
Other information
I originally attempted to look up each filetype in mime-db (#351) to determine if it should receive a charset. However, that only looks up if the file type has a "default" charset defined by the spec which is not necessarily good for friendly out-of-the box support and could have introduced breaking changes.