Remove querystring from filenames when writing to disk #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bug fix to bring file writing behavior closer to that of webpack and the WriteFilePlugin.
Did you add tests for your changes?
Yes
Summary
Webpack and the WriteFilePlugin cut off filenames at the first ?, so you can use filenames like
'[name].js?[contenthash]'
without writing hashes to your filesystem. This updates the dev middleware to do the same whenwriteToDisk
is enabled.Does this PR introduce a breaking change?
If you were using writeToDisk with a ? in
output.filename
then you won't end up with a ? in filenames on disk any more. If you pass a filter function towriteToDisk
then that function will also stop getting the querystring.Other information
Here's where querystrings get cut off in webpack and the writefileplugin:
https://github.com/webpack/webpack/blob/v4.28.4/lib/Compiler.js#L321
https://github.com/gajus/write-file-webpack-plugin/blob/v4.4.0/src/WriteFileWebpackPlugin.js#L174