Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: displayStats only logged #427

Merged
merged 6 commits into from
Jul 8, 2019
Merged

fix: displayStats only logged #427

merged 6 commits into from
Jul 8, 2019

Conversation

anchengjian
Copy link
Contributor

@anchengjian anchengjian commented Jun 24, 2019 •
edited
Loading

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

image

Breaking Changes

no Breaking Change

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jun 24, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov
Copy link

codecov bot commented Jun 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dff39a1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage          ?   97.04%           
=========================================
  Files             ?        7           
  Lines             ?      305           
  Branches          ?      103           
=========================================
  Hits              ?      296           
  Misses            ?        9           
  Partials          ?        0
Impacted Files Coverage Δ
lib/reporter.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff39a1...5a45c04. Read the comment docs.

@alexander-akait
Copy link
Member

Thanks for PR, can you solve lint problems?

@alexander-akait
Copy link
Member

Also please accept CLA

@anchengjian anchengjian changed the title displayStats only logged fix: displayStats only logged Jun 25, 2019
@anchengjian
Copy link
Contributor Author

@evilebottnawi done

@alexander-akait
Copy link
Member

@anchengjian thanks for PR, will be great create test on this, can you create example with bug?

alexander-akait
alexander-akait approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hiroppy

@alexander-akait
Copy link
Member

Great job, thanks!

@anchengjian
Copy link
Contributor Author

@hiroppy Can you help us review this PR ?

@hiroppy
Copy link
Member

hiroppy commented Jul 8, 2019

I'm sorry for the late confirmation. Thanks

@hiroppy hiroppy merged commit 98deaf4 into webpack:master Jul 8, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anchengjian @jsf-clabot @alexander-akait @hiroppy