-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getFilenameFromUrl
to API
#911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 98.59% 97.90% -0.69%
==========================================
Files 10 10
Lines 284 287 +3
Branches 100 100
==========================================
+ Hits 280 281 +1
- Misses 4 6 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this to docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will finish this PR, please always add tests and update docs in future, we can't merge new features/bugfixes without tests and docs
This PR contains a:
Motivation / Use-Case
webpack/webpack-dev-server#3299 (comment)
Breaking Changes
No
Additional Info
No