fix(utils/createLogger): ensure quiet always takes precedence (options.quiet)
#1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
|
michael-ciniawsky
changed the title
quiet is respectedquiet always takes precedence (options.quiet)
michael-ciniawsky
approved these changes
Sep 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #1486 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 10 10
Lines 666 666
=======================================
Hits 493 493
Misses 173 173
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Sep 3, 2018
|
@michael-ciniawsky looks like breaking change 😕 |
|
Strictly speaking yes, but it shouldn't 'break' anything in this case imho |
|
@michael-ciniawsky feel free to merge and release patch version |
michael-ciniawsky
added
status: approved
and removed
pr: review
priority: 3 (important)
severity: 5 (confusing)
labels
This was referenced Sep 7, 2018
6 tasks
uxtx
pushed a commit
to uxtx/webpack-dev-server
that referenced
this pull request
May 18, 2020
Dependencies: updated via `npm audit --fix`
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Doesn't look like
logLevelis currently tested, aside from validation. Also not sure how to test this~Motivation / Use-Case
Setting
noInfoandquiettotruestill reported errors (and warnings), despite the fact thatquietshould silence everything.Breaking Changes
N/A
Additional Info
Screenshot includes
wdmerror message. Also displaying the fulldevServerconfig above it.