-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add webpack as argument to before and after options #1760
feat: add webpack as argument to before and after options #1760
Conversation
/cc @hiroppy We need setup |
Which do you prefer modifying webpack-dev-server's eslint config or eslint-config-webpack? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if ci is green
@hiroppy |
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
==========================================
+ Coverage 86.85% 87.54% +0.69%
==========================================
Files 9 9
Lines 578 578
Branches 170 170
==========================================
+ Hits 502 506 +4
+ Misses 63 60 -3
+ Partials 13 12 -1
Continue to review full report at Codecov.
|
@evilebottnawi eslint-config-prettier overwrite this rule. I found that eslint-config-prettier was overriding the rules.(curly: off) So, we have to change the order https://github.com/webpack/webpack-dev-server/blob/master/.eslintrc#L2 or write this rule to webpack-dev-server's eslintrc. |
hm, it is strange, need investigate why prettier disable |
eslint-config-prettier sets 0. 😞 |
Yeah, but we are setting |
@hiroppy we need fix 👍 |
@evilebottnawi for now, I created #1761. |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Allow to get information from webpack in
before
andafter
Breaking Changes
No
Additional Info
No