Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(options): allow passing promise function of webpack.config.js #1947

Merged
merged 2 commits into from
Jun 1, 2019
Merged

fix(options): allow passing promise function of webpack.config.js #1947

merged 2 commits into from
Jun 1, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented May 31, 2019 •
edited
Loading

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yep

Motivation / Use-Case

fixes #1946, #1945

Breaking Changes

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner May 31, 2019 23:58
@hiroppy hiroppy force-pushed the fix-#1946 branch 2 times, most recently from 7bd8212 to 4c6dbee Compare June 1, 2019 00:13
hiroppy
hiroppy commented Jun 1, 2019
View reviewed changes
test/helpers/test-bin.js Outdated

stdout += str;

// if webpack.config.js is a promise function, it won't be able to call `close`
Copy link
Member Author

@hiroppy hiroppy Jun 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it wasn't able to call close, but I checked examples/general/config-promise and it works.

@codecov
Copy link

codecov bot commented Jun 1, 2019 •
edited
Loading

Codecov Report

Merging #1947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1947   +/-   ##
======================================
  Coverage    91.5%   91.5%           
======================================
  Files          18      18           
  Lines         836     836           
  Branches      263     263           
======================================
  Hits          765     765           
  Misses         68      68           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b9c70...34b5505. Read the comment docs.

@hiroppy

This comment has been minimized.

Sign in to view
@codecov

This comment has been minimized.

Sign in to view
@hiroppy hiroppy force-pushed the fix-#1946 branch 2 times, most recently from 1074179 to 479a130 Compare June 1, 2019 10:28
@codecov

This comment has been minimized.

Sign in to view
@webpack webpack deleted a comment from codecov bot Jun 1, 2019
@webpack webpack deleted a comment from codecov bot Jun 1, 2019
@codecov
Copy link

codecov bot commented Jun 1, 2019 •
edited
Loading

Codecov Report

Merging #1947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1947   +/-   ##
======================================
  Coverage    91.5%   91.5%           
======================================
  Files          18      18           
  Lines         836     836           
  Branches      263     263           
======================================
  Hits          765     765           
  Misses         68      68           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c2751...2db860f. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Jun 1, 2019
View reviewed changes
hiroppy
hiroppy commented Jun 1, 2019
View reviewed changes
test/cli.test.js
})
.catch((err) => {
// for windows
expect(err.stdout.includes('Compiled successfully.')).toEqual(true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows 😠

@codecov
Copy link

codecov bot commented Jun 1, 2019 •
edited
Loading

Codecov Report

Merging #1947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1947   +/-   ##
======================================
  Coverage    91.5%   91.5%           
======================================
  Files          18      18           
  Lines         836     836           
  Branches      263     263           
======================================
  Hits          765     765           
  Misses         68      68           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c2751...5083984. Read the comment docs.

@alexander-akait alexander-akait merged commit 8cf1053 into master Jun 1, 2019
@alexander-akait alexander-akait deleted the fix-#1946 branch June 1, 2019 14:30
@alexander-akait alexander-akait mentioned this pull request Jun 1, 2019
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Open
This was referenced Dec 14, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise based webpack configs fail
3 participants
@hiroppy @alexander-akait @evilebottnawi