-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol option is overwrited. #2083
Comments
You should not use |
Anyway please create minimum reproducible test repo with example |
Hi, So basically I am in the same situation of @Ne3l where I inject the bundle from Is there a configuration that explicity set the protocol to use for HMR? Or the only way is to enable https support for dev server (devserverhttps) and handling the complexity introduced by the security layer? |
Ok it seems that the problem is addressed here |
Overwrote not overwrited! |
Operating System: MacOs 10.14.2
Node Version: 10.15.1
NPM Version: 6.9.2
webpack Version: 4.35.2
webpack-dev-server Version: 3.7.2
This is a bug
This is a modification request
Code
Expected Behavior
Webpack-dev-server respects
http
protocol.Actual Behavior
Webpack-dev-server overwrites the
http
protocol withhtttps
For Bugs; How can we reproduce the behavior?
In our case we inject the bundle from
http://localhost:3000
insidehttps://www.domain.com
that it's mapped to our docker php application. When doing this the socket-js points tohttps://localhost:3000
instead ofhttp://localhost:3000
.This line seems responsible for this ->
webpack-dev-server/client-src/default/utils/createSocketUrl.js
Line 50 in 1581adc
For Features; What is the motivation and/or use-case for the feature?
The text was updated successfully, but these errors were encountered: