Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): proxy #5101

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(types): proxy #5101

merged 1 commit into from
Mar 11, 2024

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Just types

Motivation / Use-Case

fixes #5098

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.29%. Comparing base (8ea7cb8) to head (a2a01df).

Files Patch % Lines
lib/Server.js 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5101      +/-   ##
==========================================
- Coverage   90.30%   90.29%   -0.01%     
==========================================
  Files          15       15              
  Lines        1578     1577       -1     
  Branches      601      601              
==========================================
- Hits         1425     1424       -1     
  Misses        140      140              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 6e1aed3 into master Mar 11, 2024
39 of 41 checks passed
@alexander-akait alexander-akait deleted the issue-5098 branch March 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types of version 5.0.0 still allow proxy to be an object
1 participant