Stats / Charts broken when disk_total_space and/or disk_free_space are disabled via PHP #775
Comments
raamdev
added a commit
to wpsharks/comet-cache-pro
that referenced
this issue
Apr 6, 2017
raamdev
added a commit
to wpsharks/comet-cache-pro
that referenced
this issue
Apr 7, 2017
If `disk_total_space()` and `disk_free_space()` are disabled or otherwise not available, hide the Current Disk Health section, which won't work without these functions. wpsharks/comet-cache#775
raamdev
added a commit
to wpsharks/comet-cache-pro
that referenced
this issue
Apr 20, 2017
raamdev
added a commit
that referenced
this issue
Aug 8, 2017
- **New Feature: Memcached / RAM** (Pro): Comet Cache Pro now includes support for Memcached / AWS ElastiCache to serve the cache directly from RAM. This allows for a faster cache delivery than what is possible when serving the cache via disk. Memcached / AWS ElastiCache can be configured from **Dashboard → Comet Cache Pro → Plugin Options → RAM / Memcached**. See [Issue #47](#47) - **Enhancement**: Added `Referrer-Policy` to whitelist for cachable HTTP headers. See [Issue #892](#892). - **Bug Fix** (Pro): The Cache Statistics feature was broken when the PHP `disk_total_space()` and/or `disk_free_space()` functions were disabled by the PHP configuration. Comet Cache now handles this scenario gracefully by hiding disk-related stats when those functions are not allowed. See [Issue #775](#775) - **Bug Fix** (Pro): The HTML Compressor was returning an empty string upon encountering an invalid UTF-8 sequence. See [Issue #871](#871) reported by a Comet Cache user. - **Compatibility** (Pro): Many improvements to the Pro software update system, including changes to the API Endpoints and the Proxy Fallback endpoint. See [Issue #879](#879) and [Issue #315](wpsharks/comet-cache-pro#315) for full details. - **Compatibility**: Fixed a WooCommerce compatibility issue that was generating a "Notice: id was called incorrectly. Product properties should not be accessed directly." Props @vestaxpdx. See [Issue #896](#896).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the PHP
disk_total_space()and/or thedisk_free_space()function has been disabled by a web host (a common security practice), Comet Cache Pro does not handle the situation gracefully and instead the entire Stats / Charts section does not load (you see an indefinite spinning animation).The PHP error log reports (in the case of
disk_total_space()being disabled):We need to check if
disk_total_space()anddisk_free_space()functions are possible before using them and hide them from the "Current Disk Health" section of the page (or hide the entire "Current Disk Health" section if neither functions are available).We can use the
functionIsPossible()method for this, here and/or here, but we'll also need to updatemenu-pages.jsto hide things the way OPcache stats are hidden when appropriate and we'll also need to updateadmin-bar.jsto hide things when appropriate.The text was updated successfully, but these errors were encountered: