Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2Stream, JW Player Multiple Sources / HD Option #179

Closed
jaswrks opened this issue May 29, 2014 · 17 comments
Closed

s2Stream, JW Player Multiple Sources / HD Option #179

jaswrks opened this issue May 29, 2014 · 17 comments
Assignees
@jaswrks
Labels
enhancement framework todo
Milestone
v140816 Release

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 29, 2014

We should add support for...

JW Player Multiple Sources / HD Option
http://www.s2member.com/kb/jwplayer-s2stream-shortcodes/
See: https://websharks.zendesk.com/agent/#/tickets/2639

2014-08-14_01-44-54

2014-08-13_06-44-26
@jaswrks
Copy link
Contributor Author

jaswrks commented May 29, 2014

Docs: http://support.jwplayer.com/customer/portal/articles/1428524-hd-quality-toggling

@jaswrks jaswrks self-assigned this May 29, 2014
@jaswrks jaswrks added this to the Future Release milestone Jul 1, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 1, 2014

Moving this to the "Future Release" milestone.

@jaswrks jaswrks removed their assignment Jul 1, 2014
@jaswrks jaswrks self-assigned this Jul 21, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 21, 2014

Assigning this to myself 😸

jaswrks pushed a commit that referenced this issue Aug 10, 2014
Cleanup [s2File /], [s2Stream /] shortcodes. See: #179
61525a0
jaswrks pushed a commit that referenced this issue Aug 10, 2014
Cleanup [s2File /], [s2Stream /] shortcodes. See: #179
3c9a8e4
jaswrks pushed a commit that referenced this issue Aug 10, 2014
Add player_resolutions. See: #179
2623c46
jaswrks pushed a commit that referenced this issue Aug 10, 2014
Begin to implement player_resolutions. See: #179
cc1f42e
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Adding player_resolutions. See: #179
d66bc4d
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Implement player_resolutions. See: #179
e5321d7
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Update player templates; but with back compat. See: #179
819d8a9
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Use %%player_sources%%. See: #179
bd639b2
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Fail on error. See: #179
7e51f45
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Don't count additional resolutions against the user. See: #179
a7f442c
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Refactor %%player_sources%%. See: #179
b9fb86c
@jaswrks jaswrks mentioned this issue Aug 13, 2014
Merged
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 13, 2014

Beginning tests.

jaswrks pushed a commit that referenced this issue Aug 13, 2014
Cleanup file-related routines. See: #179
f240214
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Add CF reset button. See: #179 and #270
516d168
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Refactoring. See: #179 and #270
1f4d169
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Updating inline docs. See: #179
0588c2a
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Mention Origin Access Identities. See: #179
77800de
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 13, 2014

Second round of testing begins.

jaswrks pushed a commit that referenced this issue Aug 13, 2014
Initialize empty string. See: #179
9895b1e
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Cleanup Download Options menu page file. See: #179 and #297
418451e
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Cleanup Download Options menu page file. See: #179 and #297
645fa9d
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Bug fix; strlen/substr for resolution extension. See: #179
ed6d739
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Fix typo. See: #179
723d823
jaswrks pushed a commit that referenced this issue Aug 13, 2014
\r\n\t. See: #179
c63665c
jaswrks pushed a commit that referenced this issue Aug 13, 2014
Bug fix. Bad initialization in support of player_resolutions. See: #…
8006be8 
…179
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 13, 2014

Confirmed this is working as expected.

2014-08-13_06-44-26

@jaswrks jaswrks closed this as completed Aug 13, 2014
@clavaque
Copy link
Contributor

Great!

Was this added as a Pro feature?

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

This was implemented in the free version. Do you think it should be a pro feature?

@clavaque
Copy link
Contributor

Yeah, the free version already gives all the Download Protection features, including Amazon integration ans s2Stream. I think it's fair that any new enhancement is part of Pro. What do you think?

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Reopening this for two reasons.

  • Discussion about pro vs. lite.
  • Further testing shows a problem with RTMP and multiple resolutions.

@jaswrks jaswrks reopened this Aug 14, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Further testing shows a problem with RTMP and multiple resolutions.

Referencing: http://support.jwplayer.com/customer/portal/articles/1430398-dynamic-rtmp-streaming

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Yeah, the free version already gives all the Download Protection features, including Amazon integration ans s2Stream. I think it's fair that any new enhancement is part of Pro. What do you think?

I agree.

jaswrks pushed a commit that referenced this issue Aug 14, 2014
player_resolutions="" to require s2Member Pro. See: #179
c2b05ce
@clavaque
Copy link
Contributor

Cool. :)

@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Updating KB article here. Enhancing documentation.

2014-08-14_01-44-54

jaswrks pushed a commit that referenced this issue Aug 14, 2014
Support SMIL files. See: #179
0879b1f
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Aug 14, 2014
Support SMIL files. See: wpsharks/s2member#179
48c8033
jaswrks pushed a commit that referenced this issue Aug 14, 2014
Support SMIL files. See: #179
e68be33
jaswrks pushed a commit that referenced this issue Aug 14, 2014
Updating bit rate hints. See: #179
bb9827d
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Aug 14, 2014
Use application/smil+xml. See: wpsharks/s2member#179
2dafc14
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Beginning third round of testing.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Aug 14, 2014
true lowercase. See: wpsharks/s2member#179
b5a749c
jaswrks pushed a commit that referenced this issue Aug 14, 2014
true lowercase. See: #179
4521872
jaswrks pushed a commit that referenced this issue Aug 14, 2014
Lowercase all JS booleans after reformatting corruption. See: #179
850b99d
jaswrks pushed a commit that referenced this issue Aug 14, 2014
ceil instead of round. Also use .smil extension. See: #179
1d30970
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 14, 2014

Confirmed this is now working properly with RTMP also.

@jaswrks jaswrks closed this as completed Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaswrks jaswrks

Labels
enhancement framework todo
Projects
None yet
Milestone
v140816 Release
Development

No branches or pull requests
2 participants
@jaswrks @clavaque