Access Cap Times, Double level0 Entries?

[jaswrks]

A fork of #223 (comment)

@clavaque writes...

The access caps times log for that user (ID 20) has an entry older for level0 than the other caps, as if the account had been registered before the signup.

Array
(
[1375373865.0001] => level0
[1404804243.0001] => level0
[1404804243.0002] => level1
[1404804243.0003] => level2
)

Actually I had done a Level 1 test signup before that one (user ID 19), so I checked its times and the exact same time is there for level0 at the beginning.

Array
(
[1375373865.0001] => level0
[1404803609.0001] => level0
[1404803609.0002] => level1
)

[jaswrks]

I suspect what is causing this, is actually a bug in the WP core related to the user object cache. I am punting this to a "Future Release". We will need time to investigate it further and try to identify the cause. For now, it seems harmless enough.

[jaswrks]

Moving this to the "Next Release" milestone and assigning this to myself.

[jaswrks]

@clavaque Do you have any leads on how/why this is occurring? I'm looking now but so far I'm just not seeing how this is actually happening, or why.

[jaswrks]

I see this is NOT actually a bug, it is the intended behavior.

The first level0 comes from this line of code.

@clavaque Can you confirm this is not a bug for me please? See this line in the source code where we pull together the registration time and that is included also when it is less then the minimum. That makes sense to me, because the registration time is almost always less than the time at which a customer is actually bumped to a higher level.

[clavaque]

Yes, that logic is fine. The problem is that different users, registered at different times, have the same time for level 0...

I have a hunch the problem may be related to this line: https://github.com/websharks/s2member/blob/000000-dev/s2member/includes/classes/registration-times.inc.php#L74

It's possible that I was logged in as the admin when I created those accounts, either from the dashboard or wp-login.

What do you think?

[jaswrks]

Ah, good catch! We should be passing the $user_id when we call upon registration_time().

[jaswrks]

This has been resolved now.

[clavaque]

Excellent! :)