Revamp Pro Upgrader

[jaswrks]

• Bring it up-to-date with the latest API @ s2member.com
• Bring it up-to-date with the latest WordPress integration implemented in ZenCache and Comment Mail. As a result, make it more compatible with ZenCache also. Referencing: Cache is not cleared when s2Member Pro is updated comet-cache#508
• Rewrite the pro upgrader to clean things up (OMG, what a mess it was!), but leave the existing design for now. Mostly because the pro version is still not an official WP plugin that can be updated in the same way that our others can.
• Ask for license key instead of password.

[raamdev]

Referencing #746 where a current issue was discussed with regards to Pro-Forms on a live site showing up as plain-text when the Framework is inadvertantly updated without the Pro module also being updated. If we can figure out a way to solve that problem as part of this Pro Upgrader revamp, that would be great.

[renzms]

@jaswsinc

Tested using s2Member v170126-RC

Should it say Password, or should it only say License on the preview text in the field and instructions?

When the information is saved however, it will pull up the username and correctly input the saved License number in the field.

[jaswrks]

Hmm. I'm not sure why, but that's not the newly updated upgrade panel that I'm seeing in your screenshot. See these lines in the dev branch that were updated recently. It should ask for a license key now, not a password.

[jaswrks]

[renzms]

That's strange. No matter what I do, in a clean installation and making sure plugin deletion safeguards isn't saving anything, it still says Password.

[raamdev]

Yep, I'm seeing the same thing:

[raamdev]

DOh... if we're seeing an upgrade notice, that means that an older version of the s2Member Pro module is currently installed (with a newer version of s2Member Framework, hence the upgrade message). The older s2Member Pro module will not have the newer upgrade dialog, so what we're seeing above should be expected!

The only way to test the newer upgrade dialog would be to install the s2Member Pro v170126-RC module, and then install an s2Member Framework that is newer than v170126-RC (which doesn't exist yet).

So, the best way to test this would be to temporarily generate a newer version of the s2Member Framework (e.g., v170131-RC) and then install that with the s2Member Pro v170126-RC module in wp-content/plugins/.

[raamdev]

@renzms here's a version of s2Member Framework that is newer than the RC that you can use to test the Pro Add-On upgrade dialog: s2member-framework-2017-01-31.zip

I confirmed the new dialog showed up as expected and confirmed that the upgrade process was still working:

[raamdev]

@jaswsinc I see this item on your checklist at the top still remains:

• Bring it up-to-date with the latest WordPress integration implemented in ZenCache and Comment Mail. As a result, make it more compatible with ZenCache also. Referencing: Cache is not cleared when s2Member Pro is updated comet-cache#508

I assume the intention is to push that work to a future release, correct?

[renzms]

@raamdev

Thanks! Yes that makes more sense as to why the old version was showing up.

Confirmed Working!

[jaswrks]

@raamdev writes...

I assume the intention is to push that work to a future release, correct?

Yes. Mostly because the pro version is still not an official WP plugin that can be updated in the same way that our others can. The remaining work here is blocked by that larger problem. So for now, I just rewrote the upgrader using the same underlying concepts that it operated on previously.

[raamdev]

@jaswsinc writes...

the pro version is still not an official WP plugin that can be updated in the same way that our others can.

Hmm, it was my understanding that the last todo item up there was about doing away with the built-in Pro updater in s2Member and integrating with the native WordPress plugin updater, the way we do now in Comet Cache Pro (which is not an "official WP plugin" either...). Am I missing something?

[jaswrks]

The pro add-on in s2Member is not an installable plugin. That's the difference. So it can't be treated like an installable plugin in the updater either; i.e., if we tried to do with s2Member what we have done with Comet Cache it won't work yet.

[raamdev]

The pro add-on in s2Member is not an installable plugin. That's the difference.

Ah, got it. Thank you.

[raamdev]

s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#668).