Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After using expression editor, canvas loses focus #4293

Closed
johnsicili opened this issue Oct 15, 2024 · 1 comment · Fixed by #4318
Closed

After using expression editor, canvas loses focus #4293

johnsicili opened this issue Oct 15, 2024 · 1 comment · Fixed by #4318
Assignees
@istarkov
Labels
area:canvas Anything related to rendering on canvas prio:1 The most important thing to work on type:bug Something isn't working

Comments

@johnsicili
Copy link
Contributor

After I use the expression editor, I can't scroll on the canvas until I click on it again.

  1. Ensure the page has some room to scroll (eg 200vh)
  2. Open expression editor
  3. Click out of the expression editor, including clicking canvas directly
  4. Try scrolling canvas
  5. See no scroll 🙈
focus.mp4

Borderline P2 bug. If too much effort maybe it's P2.
@johnsicili johnsicili added type:bug Something isn't working area:canvas Anything related to rendering on canvas prio:1 The most important thing to work on labels Oct 15, 2024
@istarkov
Copy link
Member

This occurs after every dialog we have, i.e. publish etc.
This is because of Dialog's backdrops. Click is not occured on canvas but on invisible backdrop.

I don't know how to fix this.

@istarkov istarkov mentioned this issue Oct 19, 2024
Merged
7 tasks
istarkov added a commit that referenced this issue Oct 21, 2024
@istarkov
fix: Prevent tooltip on focus (#4318)
73328b3 
## Description

closes #4293

One of solution also
```
        onCloseAutoFocus={(event) => {
          event.preventDefault();
        }}
```

on dialog and popover content, but it's lost element focus.

This solution doesn't lost focus. Just prevent tooltip from being shown
on focus.


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
area:canvas Anything related to rendering on canvas prio:1 The most important thing to work on type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent tooltip on focus webstudio-is/webstudio
2 participants
@istarkov @johnsicili