Add Java Support #52
Add Java Support #52
Conversation
|
|
|
Great to see your PR with the Java support, it will be a really huge step for us that we can support Java developers! Could you please create an issue for some basic Java GRPC related information, and what we should get to know and next to do with our Java GRPC support with this PR? I'd like to learn from you more from that issue, and after I understand it, I will be able to merge this PR and move forward for the final settings for supporting the Java ecosystem by creating the java package in our Github org wechaty. Thank you very much, and I hope you have a great weekend! P.S. Also appreciate for your efforts of the Maven Central Repo creating. Link to https://issues.sonatype.org/browse/OSSRH-56843 |
pom.xml
Outdated
| <groupId>io.github.wechaty</groupId> | ||
| <artifactId>wechaty-grpc-proto</artifactId> | ||
| <packaging>jar</packaging> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
I believe this version number is the module number of our Java GRPC.
It should be sync to the exact version in our package.json.
I'm not sure the workflow between the GitHub and the Marven Central Repo, it will be great if this can be archived via the DevOps workflow (GitHub Actions in our case)
There was a problem hiding this comment.
Thank you very much for adding the Java Maven publishing support to our GRPC module, it's so great to see that we are pushing the Java language moving forward!
I have some questions and suggestions to this PR, let's discuss about it so that we can be able to merge it after everything has been clear.
|
LGTM. And it also passed our GitHub Actions for Java Building! Cheers, and thank you very much for your effort on our Java GRPC module! |
add java support