Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new vesrion with flake8 v5 support. #2514

Closed
codeleta opened this issue Oct 6, 2022 · 23 comments
Closed

Publish new vesrion with flake8 v5 support. #2514

codeleta opened this issue Oct 6, 2022 · 23 comments
Labels
rule request Adding a new rule

Comments

@codeleta
Copy link

codeleta commented Oct 6, 2022

Rule request

Publish new vesrion with flake8 v5 support.

Thesis

You made flake8 v5 support.
Can you make a tag and publish it?

Reasoning

I want update flake8 and can't do this.

@codeleta codeleta added the rule request Adding a new rule label Oct 6, 2022
@sobolevn
Copy link
Member

sobolevn commented Oct 6, 2022

Sorry, but it does not work properly: #2511

@codeleta
Copy link
Author

codeleta commented Oct 6, 2022

Oh I see. Thanks for answer.

@okainov
Copy link

okainov commented Oct 19, 2022

+1 would really love to have new version with flake8 5.x support...

Seems like it was even implemented already in #2518

@okainov
Copy link

okainov commented Nov 21, 2022

Any update on this @sobolevn ? More than a month has already passed, when do you expect creation of new release?

@sobolevn
Copy link
Member

It still does not work. flake5 is broken, sorry.

@okainov
Copy link

okainov commented Nov 21, 2022

@sobolevn thanks for clarification! But is there some open issue for the problem? Tried to briefly search, but didn't find anything really... Because from #2518 it looks like fully implemented and working (it wasn't reverted neither), could you please kindly point to what exactly is broken?

@sobolevn
Copy link
Member

@okainov
Copy link

okainov commented Nov 21, 2022

Everything is closed there :) So I think everything is fixed?

@sobolevn
Copy link
Member

Please, trying reading them: they are all closed as "won't fix".

@okainov
Copy link

okainov commented Nov 21, 2022

Well, I did read them. The most discussed/making sense issue looks like this one PyCQA/flake8#1701. In the other repos the maintainers have also already updated saying the issue was fixed (see nils-braun/b2luigi#176; python/importlib_metadata#406)

And as flake8 maintainers indeed have mentioned, submitter does use (very) out-of-date flake8 version. And that's indeed "won't fix", one cannot argue with that. And the dependency on old importlib was also fixed by flake8 maintainer in PyCQA/flake8@aa002ee.

What I tried manually just to see what's happening is to run in clean Python 3.9 container pip install importlib_metadata (which installs 5.x) and then pip install flake8 (which doesn't install any importlib_metadata and installs flake8==5.0.4). Then running flake8 on some dummy files and it seemed fine, no crashes. And that's exactly why I'm asking - what is considered "broken" here? I'd be happy to submit (one more) issue to flake8, but I don't even see the issue, it looks working fine.

root@a7afcc18ba85:/# pip freeze
flake8==5.0.4
importlib-metadata==5.0.0
mccabe==0.7.0
pycodestyle==2.9.1
pyflakes==2.5.0
zipp==3.10.0
root@a7afcc18ba85:/# flake8 --version
5.0.4 (mccabe: 0.7.0, pycodestyle: 2.9.1, pyflakes: 2.5.0) CPython 3.9.15 on Linux

@okainov
Copy link

okainov commented Nov 30, 2022

BTW flake8 6.x was recently released...

@dakotahorstman
Copy link

@okainov I'm running into this as well. Seems like @sobolevn either had something come up or he's just decided to stop maintaining the codebase. Considering his vague and unhelpful responses to you, I can't help but think the latter.

@dreamflasher
Copy link
Contributor

@sobolevn What if @okainov or someone else would make a PR with flake8 v6 that passes all tests, would you accept that PR?

@dreamflasher
Copy link
Contributor

Ping @sobolevn are you still working on wemake?

@okainov
Copy link

okainov commented Feb 17, 2023

Okay, looks like this is becoming the second rapidjson with the maintainer @sobolevn being incredibly resistant to publish new releases for noone-knows-why reason. Seems like we need to find an alternative or just go away from using this tool as this problem explicitly blocks users of new versions.

@dreamflasher
Copy link
Contributor

dreamflasher commented Feb 17, 2023

Idk what happened at rapidjson, but here it just looks like he's currently not working on the project anymore? I don't see any commits for the past 4 months. The big question is... will he ever be back?

And if he'll be back in a reasonable time, I would still think he'll update to new versions eventually. If he doesn't come back... is anybody stepping up to be the new maintainer? And sadly this means a hard fork likely, because I guess he won't give access to this repo?

@dreamflasher
Copy link
Contributor

Welcome back @sobolevn :) Would you be open for a PR that passes all tests and provides Flake8 v6 compatability?

@positron96
Copy link

Just wanted to add that currently this project cannot be used with Flake8 VSCode plugin. The oldest version of plugin that can be installed (2022.6.0) requires flake8>=5.0.0

@Day0Dreamer
Copy link

@dreamflasher - Do you have a fork I can use?

I'm afraid the noone-knows-why reason, @okainov mentioned, won't go away for the duration of 2023.

I'm looking forward to keep using the updated version of this great tool. Got to keep the wheel turning

@dreamflasher
Copy link
Contributor

I stopped using wemake. As @sobolevn is back and working on PRs, but not responding here/not working on this issue, I also doubt this will be resolved any time soon.
I'd appreciate a lot if you create a fork that works with current dependencies!

@Day0Dreamer
Copy link

@dreamflasher it would look like @sobolevn is plowing through the backlog. We've got to be patient. <3

@dolfinus
Copy link
Contributor

dolfinus commented Jun 1, 2023

Finally https://github.com/wemake-services/wemake-python-styleguide/releases/tag/0.18.0

@dreamflasher
Copy link
Contributor

Thank you very much @sobolevn !

@sobolevn sobolevn closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule request Adding a new rule
Projects
None yet
Development

No branches or pull requests

8 participants